QFileSystemWatcher's signal "directoryChanged" not emitted
-
Hi,
I have deleted (not shift+delete) a directory that contains files under Windows 10.
In my app that tests the QFileSystemWatcher, I have seen that there is not any directoryChanged signal for that directory that is emitted.(the watcher watch a parent directory of this directory)
Should I register a Qt Bug ?
I use the QFileSystemWatcher in another app, a file synchronisation software that is fast finished....
The first bug that I have registered is reported... -
Hi stephane78,
you say: "the watcher watch a parent directory of this directory".
The docs (http://doc.qt.io/qt-5/qfilesystemwatcher.html#addPath) do not mention that any subfolders are watched.
So I think you need to add all subfolders recursively starting from your parent directory to get the directoryChanged signal for
a subfolder. -
Hi stephane78,
you say: "the watcher watch a parent directory of this directory".
The docs (http://doc.qt.io/qt-5/qfilesystemwatcher.html#addPath) do not mention that any subfolders are watched.
So I think you need to add all subfolders recursively starting from your parent directory to get the directoryChanged signal for
a subfolder.@sneubert I know that, and all the paths are added recursively at the beginning of my app and are added too when copying a new directory into the path.so the watcher watch this path but doesn't emit a directoryChange signal for this path(subdirectory) when deleting (not shift +del) under Windows 10....
so I will perhaps put a new Qt BUG
does someone know if we buy a subscription if the people of Qt will correct this two bugs (this one and the older)? because we need QFileSYstemWatcher for our app and I have signaled the other bug since march 2016 and it is reported since. -
Hi,
What bug is it ?
-
@SGaist I have reported this bug :https://bugreports.qt.io/browse/QTBUG-59616
(and my older bug on QfileSystemWatcher is 52226)regards
-
Like suggested in both report, please provide a minimal compilable example.
For it has two purposes: see what code triggers the problem and allows to build the example on other platforms.
-
Like suggested in both report, please provide a minimal compilable example.
For it has two purposes: see what code triggers the problem and allows to build the example on other platforms.
@SGaist I have now uploaded a minimal project to test and display directorychange and filechange but it is not complete because it does'nt add the paths to watcher when adding new path....
we use Qt -LGPL in our little company and (at home for personal projects)
if our company buy a commercial license for three months, will be the two bugs be corrected ? -
Like suggested in both report, please provide a minimal compilable example.
For it has two purposes: see what code triggers the problem and allows to build the example on other platforms.
@SGaist if this project is not sufficient I will perhaps provide the whole code but this code belongs to my company......
Buying a commercial license will perhaps help us to solve the two bugs? -
Paying customer bug will have more weight however I don't know how fast it will make things. I'm not working for the Qt Company and can't comment on such matter.
-
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin I didn't try all the OS, but I can later, but under linux there isn't any difference between del and shift+del like under windows (because I tested that with del under win10 so when you put the folder in the trashcan, but did'nt test really with shift+del...I think with shift+del under win7 it is ok but not sure 100%
I will do more test so....
but I have already looked at the code of QFile SystemWatcher for one year because of the older bug and I don't really understand it....if I could understand it I would have made myself the correction.I will try again to look at the code of QFileSystemWatcher -
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin OK there is the same problem under linux debian 8 with kde.when you move to thrash a subdirectory watched the signal directorychanged is not emitted and when you delete it with shift+del the signal is emitted...I have just tested now
under windows 7 I can only delete with shift+del it doesn't allow me to delete with del so there isn't any problem
I didn't test under mac os -
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin I have looked quickly at the source code of QFileSystemWatcher....(Qt5.6.2)
first I don't find the definition of init() and initPollerEngine() of the class QFileSystemWatcherPrivate (qfilesystemwatcher_p.h) that are called in the constructor of QFileSystemWatcher and in the method addPaths.
second, I have seen that there is a thread that derivate from QThread for windows, QWindowsFileSystemWatcherEngineThread, and the method run is redefinited l332 in qfilesystemwatcher_win.cpp,so that I understand it but don't understand all the details in the method run... -
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin I have seen where it emits the signal directoryChanged when the directory is deleted l.388 and l.385 I see if(fakeRemove||!fileInfo.exists()) but I don't understand the other things well.....
-
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin I have looked too at the win32 functions findfirstchangenotification (used l.160) and find nextchangenotification (used l.364)....I think I must use a debug version of Qt to debug that because perhaps there is no change notification on the handle when we use a simple del to delete a directory ie send it to trashcan(without shift) ?
-
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin or perhaps the error l.367 is another error than ERROR_ACCESS_DENIED that should be considered too and the that fakeRemove should be put to true too (or another boolean )
-
Might be worth you looking directly at the source code, see if you can get it sorted yourself, and submit a patch.
Did you try if other environments are affected too? Any linux distribution for example?
@VRonin what are the other errors of FindNextChangeNotification?didn't find them in the win32 msdn documentation.
And I don't really know how to do debug of Qt ? because it is in QtCore,so I suppose I must take the project and source of QtCore, but my test project use not only QtCore but QtGui and QtWidget too.... -
@VRonin Thank you vronin, do you know how I can debug QtCore (or corelib or io) with my test project synchro as executable with QtCreator and mingw-w64(the compiler of qt.io).I suppose I must take the source (single,the .zip) but don't really know how to do that.my project synchro uses core,gui and widget but I suppose I must open corelib or io as project in QtCreator
-
@VRonin do you know how to get the version 5.6.2 of qtbase from code.qt.io with git? (to build it in debug and try to debug corelib)
