QFontDialog::getFont() doesn't use correct font style
-
@kshegunov, I already found that bug and was wondering if that's what's affecting QOwnNotes. Thank you for making that clear!
Yes, you are right. If you use the font directly it works, but it doesn't work with
font2.fromString(font.toString());that is needed to store and load it to/from the settings. Do you have any ideas to get around this?@pbe said:
Do you have any ideas to get around this?
Sadly, no. The bug seems inherent to the
QFontDialogclass when theQFont's internal identifier isn't set (i.e. when the dialog needs to go and query about the font by its attributes). If I get some more time in the coming days, I'll try to run it again and hopefully will have something better.Kind regards.
-
@kshegunov, thank you very much! You are my hero!
-
@pbe
I have a bug fix and I'll try to submit it this evening (I've been working in the dev branch, so some git magic is needed).Kind regards.
-
@kshegunov, really? That's wonderful! I can't wait to see it!
@pbe
https://codereview.qt-project.org/#/c/165958/We'll see if it gets approved.
-
@kshegunov, that really is what I'm encountering... So actually two bugs are triggered here...
-
@pbe
QTBUG-54936's been merged and the patch will be incorporated in Qt 5.8Kind regards.
-
@kshegunov, great news! Thanks a lot!
-
@pbe
My pleasure. The dialog bug is low(er) priority and it may take some time for the proposed patch to get reviewed.Kind regards.
-
@kshegunov I wonder if it will get fixed at all...
-
@pbe
It's going to, it'ill just take some time. Now things a bit slow because most people are on vacation.@kshegunov, humans... :)
