Classes communication / signal slot generates duplicate connection error

angelicaP

@MainWindow *pmainWindowRef;@

gives me the following error:
"MainWindow does not name a type;",
with
@#include "mainwindow.h"@
and with
@class MainWindow@
included

my question is: why I don't receive the same error for other classes, like
@formCreate *fC;@

any idea?

SGaist

Before going any further, what do you want to achieve with FromSelect ?

angelicaP

FormSelect is only a form where the pushButtonCreate is located, and the idea is if I emit the _clicked() _ signal of this button, the formCreate should be opened in MainWindow, into a new tab of the already existing tabWidget.

formSelect is only a transitional phase.

thank you.

SGaist

Then you should only forward the clicked signal from that widget and do the connection directly in MainWindow.

angelicaP

hi,

I edited the subject, because the post has changed from the original one.

I'm sure this issue is not rocket science, but for me is a no go.
I tried to reduce my examples to minimum, only to establish this connection. I tried to create the connection in MainWindow as you mentioned. here are is my complete code:

@// dialog2.cpp

#include "dialog2.h"
#include "ui_dialog2.h"

Dialog2::Dialog2(QWidget *parent) :
QDialog(parent),
ui(new Ui::Dialog2)
{
ui->setupUi(this);
}

Dialog2::~Dialog2()
{
delete ui;
}

// dialog2.h

#ifndef DIALOG2_H
#define DIALOG2_H

#include <QDialog>

namespace Ui {
class Dialog2;
}

class Dialog2 : public QDialog
{
Q_OBJECT

public:
explicit Dialog2(QWidget *parent = 0);
~Dialog2();

signals:
void on_pushButton_clicked();

private:
Ui::Dialog2 *ui;
};

#endif // DIALOG2_H

//dialog1.cpp
#include "dialog1.h"
#include "ui_dialog1.h"

Dialog1::Dialog1(QWidget *parent) :
QDialog(parent),
ui(new Ui::Dialog1)
{
ui->setupUi(this);
}

Dialog1::~Dialog1()
{
delete ui;
}

//dialog1.h
#ifndef DIALOG1_H
#define DIALOG1_H

#include <QDialog>

namespace Ui {
class Dialog1;
}

class Dialog1 : public QDialog
{
Q_OBJECT

public:
explicit Dialog1(QWidget *parent = 0);
~Dialog1();

private:
Ui::Dialog1 *ui;
};

#endif // DIALOG1_H

//mainwindow.h
#ifndef MAINWINDOW_H
#define MAINWINDOW_H

#include <QMainWindow>
#include <QTabWidget>

namespace Ui {
class MainWindow;
}

class MainWindow : public QMainWindow
{
Q_OBJECT

public:
explicit MainWindow(QWidget *parent = 0);
~MainWindow();

private:
Ui::MainWindow *ui;

private slots:
void addNewTab(QWidget *page, QString &title)
{
QTabWidget *newTab = new QTabWidget;
setCentralWidget(newTab);
newTab->addTab(page, title);

};

#endif // MAINWINDOW_H

//mainwindow.cpp
#include "mainwindow.h"
#include "ui_mainwindow.h"
#include "dialog1.h"
#include "dialog2.h"

MainWindow::MainWindow(QWidget *parent) :
QMainWindow(parent),
ui(new Ui::MainWindow)
{
ui->setupUi(this);
Dialog1 *d1 = new Dialog1;
Dialog2 *d2 = new Dialog2;
QString title = "title test1";

connect(d2, SIGNAL(on_pushButton_clicked()), this, SLOT(addNewTab(QWidget* , QString&)));

}

MainWindow::~MainWindow()
{
delete ui;
}@

this give me the following error:
"QObject::connect: Incompatible sender/receiver arguments
Dialog2::on_pushButton_clicked() --> MainWindow::addNewTab(QWidget*,QString&)"

because the signal is not the same type as the slot, "forcing the socket". so my existential question is, how to connect this pushButton with the slot "addNewTab"; desired action is to understand the communication between these classes when a widget should be opened in a tabWidget in the MainWindow.

thank you for your support.

SGaist

You can't establish that connection, a slot must have either the same list of arguments as the signal or less but still matching from left to right.

angelicaP

is there any other solution available besides connect (signal/slot) to make this pushButton open a dialog form?

angelicaP

I don't understand, there should be a way to connect this pushButton. maybe to connect it to an intermediate slot? any idea? thank you.

andreyc

In the implementation of addNewTab you replace a central widget of a MainWindow. It means that a QTabWidget will have only one tab always.
@
void addNewTab(QWidget *page, QString &title)
{
QTabWidget *newTab = new QTabWidget;
setCentralWidget(newTab);
newTab->addTab(page, title);
}
@

Question: How do you provide page and title for *addNewTab(QWidget page, QString &title) ?

angelicaP

bq. In the implementation of addNewTab you replace a central widget of a MainWindow. It means that a QTabWidget will have only one tab always.

I'm confused. this is what I was doing before. please check the line 115 in my above code.

bq. Question: How do you provide page and title for addNewTab(QWidget *page, QString &title) ?

via line 138, but is not working because the signal and the slot doesn't have the same type.

andreyc

[quote author="angelicaP" date="1402512166"][quote]In the implementation of addNewTab you replace a central widget of a MainWindow. It means that a QTabWidget will have only one tab always.[/quote] I'm confused. this is what I was doing before. please check the line 115 in my above code.[/quote]
Right, you were replacing centralWidget on each call to addNewTab().
I don't think that it is what you wanted.

[quote author="angelicaP" date="1402512166"][quote]Question: How do you provide page and title for addNewTab(QWidget *page, QString &title) ?[/quote]
via line 138, but is not working because the signal and the slot doesn't have the same type.[/quote]
No, in the line 138 you are trying to set a connection between some signal and some slot. In the slot you expect to get page and title.
My question is where do you get those page and title initially?
Does it come from the form that you are trying to create or do you read it from a file?
BTW you need to create page somewhere.

angelicaP

bq. Right, you were replacing centralWidget on each call to addNewTab().
I don’t think that it is what you wanted.

I see now. that means if I remove the setCentralWidget, I need to make sure it's created somewhere else.

bq. No, in the line 138 you are trying to set a connection between some signal and some slot. In the slot you expect to get page and title.
My question is where do you get those page and title initially?
Does it come from the form that you are trying to create or do you read it from a file?
BTW you need to create page somewhere.

my initial thought was to
@Dialog1 *d1 = new Dialog1;
Dialog2 *d2 = new Dialog2;
QString title = "title test1";
connect(d2, SIGNAL(on_pushButton_clicked()), this, SLOT(addNewTab(d1, title)));@

instead of

@ Dialog1 *d1 = new Dialog1;
Dialog2 *d2 = new Dialog2;
QString title = "title test1";

connect(d2, SIGNAL(on_pushButton_clicked()), this, SLOT(addNewTab(QWidget* , QString&)));

@

but this is not feasible because the way the slot is defined
@void addNewTab(QWidget *page, QString &title)@
is not the same with
@connect(d2, SIGNAL(on_pushButton_clicked()), this, SLOT(addNewTab(d1, title)));@

here I received the error: "QObject::connect: No such slot MainWindow::show(addNewTab(QWidget*, QString&))"

in this case,
@connect(d2, SIGNAL(on_pushButton_clicked()), this, SLOT(addNewTab(QWidget* , QString&)));@
i receive the error: "QObject::connect: Incompatible sender/receiver arguments"

does this make sense?
so, what's the correct way to do it? thank you for your help

SGaist

You can't pass parameters in connect statements (please take some time to read the "Signals And Slots" chapter in Qt's documentation.

What's the use of Dialog2 ? Get a string from the user ? Then call exec on the dialog. Check it's return value. If it's okay then call directly addNewTab retrieving the string from Dialog2 through a getter.

angelicaP

hi,
when I simplified my test example I missed a detail. sorry for this, a lot of effort has already been put in this thread: in mainWindow I have an action when triggered, opens dialog1. In dialog1 is the pushButton that should open dialog2. maybe this makes sense. how is this scenario changes the output.

bq. You can’t pass parameters in connect statements (please take some time to read the “Signals And Slots” chapter in Qt’s documentation.

understood from Signals and Slots.

below my code from mainWindow.h and .cpp. the rest remains as in my previous post - entire code.

@//mainwindow.h
#ifndef MAINWINDOW_H
#define MAINWINDOW_H

#include <QMainWindow>
#include <QTabWidget>
#include "dialog1.h"
#include "dialog2.h"
#include <QMessageBox>
#include <QString>
#include <QWidget>

namespace Ui {
class MainWindow;
}

class MainWindow : public QMainWindow
{
Q_OBJECT

public:
explicit MainWindow(QWidget *parent = 0);
~MainWindow();

private:
Ui::MainWindow *ui;

private slots:
void addNewTab(QWidget * page, QString & title)
{
QTabWidget *newTab = new QTabWidget;

    setCentralWidget(newTab); // only for testing, otherwise generates one single tab always. previous post
    newTab->addTab(page, title);
    newTab->setTabsClosable(true);
}
void on_actionDialog1_triggered();

};

#endif // MAINWINDOW_H

//mainwindow.cpp
#include "mainwindow.h"
#include "ui_mainwindow.h"
#include "dialog1.h"
#include "dialog2.h"
#include <QTabWidget>

MainWindow::MainWindow(QWidget *parent) :
QMainWindow(parent),
ui(new Ui::MainWindow)
{
ui->setupUi(this);
Dialog1 *d1 = new Dialog1;
Dialog2 *d2 = new Dialog2;

//here should come the connect function that connects dialog1 to open a dialog2 in mainwindow tabWidget. this is generating my problem.

}

MainWindow::~MainWindow()
{
delete ui;
}

void MainWindow::on_actionDialog1_triggered()
{
QString titled1 = "title d1";
Dialog1 *d1 = new Dialog1;
addNewTab(d1, titled1);
}@

SGaist

If Dialog2 is open within Dialog1, what does it do in MainWindow ?

angelicaP

dialog2 should be open by dialog1 within the tabWidget in MainWindow.

SGaist

What does Dialog1 contain ? How should it be shown ?

angelicaP

thank you for your feedback,

@//dialog1.cpp
#include "dialog1.h"
#include "ui_dialog1.h"
#include "mainwindow.h"

Dialog1::Dialog1(QWidget *parent) :
QDialog(parent),
ui(new Ui::Dialog1)
{
ui->setupUi(this);
Dialog2 *d2 = new Dialog2;
QString titled2 = "title d2";

connect(this, SIGNAL(on_pushButton_clicked()), d2, SLOT()); // and the slot should be the function defined that adds a new tab in the tabWidget
}

Dialog1::~Dialog1()
{
delete ui;
}

//dialog1.h
#ifndef DIALOG1_H
#define DIALOG1_H

#include <QDialog>
#include <QTabWidget>

namespace Ui {
class Dialog1;
}

class Dialog1 : public QDialog
{
Q_OBJECT

public:
explicit Dialog1(QWidget *parent = 0);
~Dialog1();

signals:
void on_pushButton_clicked();

private:
Ui::Dialog1 *ui;
};

#endif // DIALOG1_H

//and the function addNewTab is defined in dialog2.h
//dialog2.h
#ifndef DIALOG2_H
#define DIALOG2_H

#include <QDialog>2
#include <QTabWidget>

namespace Ui {
class Dialog2;
}

class Dialog2 : public QDialog
{
Q_OBJECT

public:
explicit Dialog2(QWidget *parent = 0);
~Dialog2();

private slots:
void addNewTab(QWidget * page, QString & title)
{
QTabWidget *newTab = new QTabWidget;

   // setCentralWidget(newTab);
    newTab->addTab(page, title);
    newTab->setTabsClosable(true);
}

signals:
void on_pushButton_clicked();

private:
Ui::Dialog2 *ui;
};

#endif // DIALOG2_H@

SGaist

Why does Dialog1 create a Dialog2 instance ?
Why does Dialog2 create a QTabWidget ?

You are mixing together everything. If something done in Dialog1 should trigger something in MainWindow then it should not happen in Dialog2.

You should do some sketches of what each widget of your application should do. Are you sure you need all these dialogs ?

angelicaP

thanks for your input. I have the impression that I'm mixing all. let's say dialog1 it's a window with some widgets in, and dialog2 it's a filter, or son of the dialog1.
all windows are opened in mainWindow in tabWidget.

as soon as dialog1.pushButton is trigged, the dialog2 opens in a new tab in mainWindow. this is what should happened.