[SOLVED] Qt5 + VS2010 QDateTime => not enough actual parameters for macro 'min' & 'max'

AcerExtensa

Hi,
I'm playing with Qt5 and have successfully compiled it from GIT under Windows 7 + VS 2010. It works(in most cases), but when I include <QDateTime> header it breaks whole compilation with following errors:

@
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(123): warning C4003: not enough actual parameters for macro 'min'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(124): warning C4003: not enough actual parameters for macro 'min'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(125): warning C4003: not enough actual parameters for macro 'max'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(123): error C2589: '(' : illegal token on right side of '::'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(123): error C2059: syntax error : '::'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(124): error C2589: '(' : illegal token on right side of '::'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(124): error C2059: syntax error : '::'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(125): error C2589: '(' : illegal token on right side of '::'
1>c:\QT\QT5_X86_GIT\qtbase\include\QtCore/qdatetime.h(125): error C2059: syntax error : '::'
@

This lines in datetime.h header make VS go crasy:
@
static inline qint64 nullJd() { return std::numeric_limits<qint64>::min(); }
static inline qint64 minJd() { return std::numeric_limits<qint64>::min() / 2; }
static inline qint64 maxJd() { return (std::numeric_limits<qint64>::max()) / 2; }
@

It happens only if you include <windows.h> in your project. And can be eliminated by defining NOMINMAX before windows.h headers. But it feels somehow broken...

Does anyone has this problem too?

nadir

Same problem, Qt5 RC2 Visual Studio 2010

AcerExtensa

#define NOMINMAX before including windows.h header. This is only way at the moment...

andishock

Hello,

on some projects I get the same warnings and errors, though there is no include of windows.h.
What else can cause this problem and how can I avoid it.

Thanks for suggestions.

Edit: Setting a compiler switch "/DNOMINMAX" fixed the problem.

iphenion

Yes, still the same problem here: Qt5.0.2 32bit MSVC2010

djszapi

Hitting with 5.1.0 RC2 as well. I am using 32 bit MSVC2010 and the default variant (angel?).

http://download.qt-project.org/snapshots/qt/5.1/5.1.0-rc2/backups/2013-06-25-65/qt-windows-opensource-5.1.0-rc2-msvc2010-x86-offline-2013-06-25-65.exe

MaximAlien

Did you try switching to VS2012? I encountered the same problem

Violet Giraffe

You should define NOMINMAX when including <windows.h>. Period. And WIN32_LEAN_AND_MEAN, by the way.

djszapi

@MaximAlien: Nope, the customer was stuck to 2010.

@Violet Giraffe: yes, it was mentioned above what to do, so we are aware of that. However, it would be nice to fix centrally in the Qt Project if possible. If not, it would be nice to be aware of the limitation why it is not possible.

MaximAlien

Defining like that:
@#define NOMINMAX
#include <windows.h>@
doesn't help me. Can you help me guys?

I have compilation errors in:
@static inline qint64 nullJd() { return std::numeric_limits<qint64>::min(); @

I have 2 windows.h includes in other classes.

djszapi

MaximAlien: have you tried "/DNOMINMAX"?

or DEFINES += NOMINMAX with qmake?

MaximAlien

Thanks for help Laszlo! Defining @DEFINES += NOMINMAX@ in pro file helped me.

sdolard

Use this include "#include <*qt_*windows.h>" instead of #include <windows.h>

djszapi

@sdolard: that will not ultimately help.

Also, not sure what you mean by stars in there.

sdolard

@Laszlo Papp
Sure, but qt_windows.h already include a define for NOMINMAX, and other stuffs. So it's better to use it.

Chars between * should be bolded.

djszapi

sdolard: the problem is that, it does more than what you need, so not compact enough. :)

More importantly, you need to find and maintain the right place for the include. If you do it in the build system, it always works.

Also, even though qt_windows.h is installed publicly, you could include anytime. However, if you wanna be nice, you would use qt win ifdefs around just in case, but then it is getting uglier. :)

But yes, provided those drawbacks are not real problems, that also works.

XGuy

[quote author="AcerExtensa" date="1355825116"]#define NOMINMAX before including windows.h header. This is only way at the moment...[/quote]

Hi
i had the same problem and got it working by following your suggestion.
thx.

frankiefrank

This thread helped me out with this issue. THANK YOU.

DimitriJunker

Hi,

I have the same problem, but without an include of windows.h. So I can not enter a define before it and including
DEFINES += NOMINMAX
in the pro-file did'nt worked either.
Any more ideas?

DimitriJunker

Hi,

since I started the project I had to reinstall windows and so qt creator. Originaly i used mingw. Now I also installed mingw, but somehow the installation was not compleat and qt creator used msvc instead. After swiching back to mingw I got rid of the error. So it's solved for me, but others might have the same problem.

Dimitri