[Solved] Amending commits for Gerrit

[JKSH]

I've just pushed some changes to Gerrit, but the Sanity Bot flagged style issues (trailing whitespace). So, I:

Removed the trailing whitespace, saved the file

Did `git commit --amend', retaining the original commit message

Did `git push ssh://JKSH@codereview.qt-project.org:29418/qt/qtbase HEAD:refs/for/master'

Gerrit rejected my push, saying "No changes made". What am I missing?

[JKSH]

Answer: Need to do git add __________' before git commit --amend'

[lgeyer]

On a sidenote: make sure Change-Id is included in the amended commit message. Otherwise gerrit will create a new change instead of a patchset.

[JKSH]

Thanks for the tip; I'll keep that in mind