Important: Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct
[Solved] Amending commits for Gerrit
I've just pushed some changes to Gerrit, but the Sanity Bot flagged style issues (trailing whitespace). So, I:
Removed the trailing whitespace, saved the file
Did `git commit --amend', retaining the original commit message
Did `git push ssh://JKSH@codereview.qt-project.org:29418/qt/qtbase HEAD:refs/for/master'
Gerrit rejected my push, saying "No changes made". What am I missing?
Answer: Need to do
git add __________' beforegit commit --amend'
lgeyer last edited by
On a sidenote: make sure Change-Id is included in the amended commit message. Otherwise gerrit will create a new change instead of a patchset.
Thanks for the tip; I'll keep that in mind