Important: Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct
[SOLVED] Contribution problem ...
[This may be unrelated to this forum! Unfortunately I can't find any support thing on qt.gitorious.org]
I want to add a merge request to Qt repository, but gitorious unable to fetch commits of 4.8 branch. It freezes like this:
Charles last edited by
Don't add merge request to qt.gitorious.org, gitorious now just acts as the git repo mirror. Please push your patch to codereview.qt-project.org (you need a JIRA account to do this, create one from bugreports.qt-project.org if you don't have). More info at http://qt-project.org/contribute .
oops! everything has been changed since last year !
[quote author="Charles" date="1345724779"]Don't add merge request to qt.gitorious.org, gitorious now just acts as the git repo mirror. Please push your patch to codereview.qt-project.org (you need a JIRA account to do this, create one from bugreports.qt-project.org if you don't have). More info at http://qt-project.org/contribute . [/quote]What about the repositories that do not exist in Gerrit, like the Qt Solutions Archive?
I still can't get rid of Gerrit
git remote -v
gerrit ssh://firstname.lastname@example.org:29418/qt/qt.git (fetch)
gerrit ssh://email@example.com:29418/qt/qt.git (push)
git push gerrit 4.8
Enter passphrase for key '/home/soroush/.ssh/id_rsa':
Counting objects: 11, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 30.43 KiB, done.
Total 8 (delta 6), reused 0 (delta 0)
remote: Resolving deltas: 0% (0/6)
! [remote rejected] 4.8 -> 4.8 (prohibited by Gerrit)
error: failed to push some refs to 'ssh://firstname.lastname@example.org:29418/qt/qt.git'
What's prohibited by Gerrit ?
You can not push into branches directly with gerrit. That would go around the CI system and the review process.
You need to @git push gerrit refs/for/4.8@ so that gerrit knows it is supposed to create a review request. Note that you need to have "gerrit set up":http://qt-project.org/wiki/Setting-up-Gerrit properly before doing that. The "Local Setup" part is the most important as it adds a hook to your git repo that adds Change Ids to your commits.
See also "Introduction to Gerrit":http://qt-project.org/wiki/Gerrit-Introduction.
The new contribution mechanism seems to be much more complicated than the old, lovely gitorious :)
Honestly, it actually isn't and once you got your head around it you'll never want to do without it again ;-)
[quote author="Lukas Geyer" date="1345824349"]Honestly, it actually isn't and once you got your head around it you'll never want to do without it again ;-)[/quote]
I hope so !
soroush: The new system is really straight forward to use after the initial setup... The good thing about it is that it is the same system for everybody.
With gitorious the Nokians pushed directly while everybody else had to go through the merge request system. So your chances to get your code reviewed and merged are much higher now: The approvers/maintainers (most are still in Nokia after all) actually are using the tool you use to submit your code so they will notice. Since the process of merging contributions is much simpler, too (with the gitorious-based process Nokias legal department was involved in each merge request!), your chances of getting merged are much higher, too.