Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. General and Desktop
  4. (seemingly) simple Qt app: creating a progress bar
Forum Updated to NodeBB v4.3 + New Features

(seemingly) simple Qt app: creating a progress bar

Scheduled Pinned Locked Moved General and Desktop
72 Posts 5 Posters 61.0k Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • G Offline
    G Offline
    goetz
    wrote on last edited by
    #63

    Can you put your current code into a ZIP for downloading? Just replace the actual workload in the run method with some dummy loop. It's hard to say what's going on without seing the whole picture.

    http://www.catb.org/~esr/faqs/smart-questions.html

    1 Reply Last reply
    0
    • mzimmersM Offline
      mzimmersM Offline
      mzimmers
      wrote on last edited by
      #64

      Sure, I can do that. Where would you like me to put it? Or, I can email it to you.

      Thanks, Volker.

      EDIT: Just remembered this site. Here's the zip:

      http://www.mediafire.com/download.php?qp6lelkebbni20i

      Thanks again.

      1 Reply Last reply
      0
      • G Offline
        G Offline
        goetz
        wrote on last edited by
        #65

        Ok, I made it run as expected. First, I had a mistake in my outline of the onQuitButtonClicked() method. The call to close() wasn't conditional, it was always called, that's why your app close, even if you clicked on "no".

        To make it run:

        add a signal workDone() to WorkerThread:
        @
        signals:
        void percentChanged(int percent);
        void workDone();
        @

        emit the signal at the end of the run method:
        @

        void WorkerThread::run()
        {
        qDebug() << "WorkerThread::run(): STARTED";

        // your code goes here.
        
        myFile.close();
        qDebug() << "WorkerThread::run(): finished";
        emit workDone();
        

        }
        @

        in the MainWindow constructor connect the signal:
        @
        MainWindow::MainWindow(QWidget *parent) :
        QMainWindow(parent)
        {
        // ...

        connect(m_worker,
                SIGNAL(workDone()),
                m_thread,
                SLOT(quit()));
        // ...
        

        }
        @

        modify MainWindow::onQuitButtonClicked() to this version
        @
        void MainWindow::onQuitButtonClicked()
        {
        QMessageBox::StandardButton answer = QMessageBox::question(
        this,
        tr("Quit applicaton?"),
        tr("Do you really want to quit the application?"),
        QMessageBox::Yes | QMessageBox::No,
        QMessageBox::No
        );

        if (answer != QMessageBox::No)
        {
            if(m_thread->isRunning()) {
                qDebug() << "thread is running - trying to terminate it";
                emit requestWorkerToFinish(); // no direct call!
                bool finishOk = m_thread->wait(10000);
                if (!finishOk)
                {
                    qDebug() << "WARNING: request to finish thread timed out!";
                    m_thread->terminate();
                    m_thread->wait();
                }
            } else {
                qDebug() << "Thread not running";
            }
            close();
        }
        

        }
        @

        Some additional hints:

        At the end of a method that has no (void) return type, you do not need to call return explicitly.

        All the QObjects you create using new() should have a parent:

        @
        MainWindow::MainWindow(QWidget *parent) :
        QMainWindow(parent)
        {
        m_bar = new QProgressBar (this);
        m_button = new QPushButton (this);
        m_worker = new WorkerThread (this);
        m_thread = new QThread (this);

        setupWidgets();
        // ...
        

        }
        @

        If they do have a parent, you do not need to delete them manually, so remove the deletes from the destructor:

        @
        MainWindow::~MainWindow()
        {
        }
        @

        And to have a nice layout, you should put everything into a layout or use a Qt Designer based form.

        http://www.catb.org/~esr/faqs/smart-questions.html

        1 Reply Last reply
        0
        • mzimmersM Offline
          mzimmersM Offline
          mzimmers
          wrote on last edited by
          #66

          Hmm...it's not working as I'd expect it to. Here's the app output when I push the "yes" button:

          bq. WorkerThread::run(): STARTED
          thread is running - trying to terminate it
          WorkerThread::run(): finished
          reached end of file.
          WARNING: request to finish thread timed out!
          The program has unexpectedly finished.

          Based on my telltales in run(), it appears that the slot requestFinish() isn't called until run() is finished. I added a telltale to requestFinish(), and here's the output I got:

          bq. WorkerThread::run(): STARTED
          thread is running - trying to terminate it
          reached end of file.
          WorkerThread::requestFinish() called.
          WorkerThread::run(): finished
          WARNING: request to finish thread timed out!
          The program has unexpectedly finished.

          Another issue: this line in mainwindow.cpp doesn't compile:

          @ m_worker = new WorkerThread (this);
          @

          Perhaps this is because my c'tor didn't have an argument, so I modified its declaration to be this:

          @ WorkerThread(QObject * parent = 0);
          @

          Now it compiles (though I get a compiler warning that parent is never used). Is this OK?

          1 Reply Last reply
          0
          • G Offline
            G Offline
            goetz
            wrote on last edited by
            #67

            Nope, you must also change the constructor implementation:

            @
            WorkerThread::WorkerThread(QOjbect parent)
            : QObject(parent)
            {
            // ...
            }
            @

            It is always a good idea to always add the parent parameter to any QObject subclass. If you use the new class wizard in Qt Creator, it's even done automatically, if you state that it is a QObject subclass :-)

            Regarding the finish: I need to prepare a test case, my files were far too small to add reasonable workload to the worker thread. It was always finished before I had the chance to click the button :)

            http://www.catb.org/~esr/faqs/smart-questions.html

            1 Reply Last reply
            0
            • mzimmersM Offline
              mzimmersM Offline
              mzimmers
              wrote on last edited by
              #68

              Hmm, I now get a run-time warning/error:

              bq. QObject::moveToThread: Cannot move objects with a parent

              The documentation on QObject confirms this.

              Also:

              bq. And to have a nice layout, you should put everything into a layout or use a Qt Designer based form.

              ...meaning, that I don't use Designer to create the UI, but I somehow move my existing stuff into Designer context? If you could point me at a page that talks more about this, I'll get started on it.

              Thanks.

              1 Reply Last reply
              0
              • G Offline
                G Offline
                goetz
                wrote on last edited by
                #69

                Ah, I'm the cause of the error. Just replace this one

                @
                m_worker = new WorkerThread (this);
                @

                with this one:

                @
                // The WorkerThread has no parent
                m_worker = new WorkerThread;
                @

                In this case you must delete the worker in the destructor to avoid a memory leak:

                @

                MainWindow::~MainWindow()
                {
                delete m_worker;
                }
                @

                For the layout: You can either use Qt Designer or just put everything into a layout manally, the [[Doc:QLayout]] docs and subclasses have examples.

                http://www.catb.org/~esr/faqs/smart-questions.html

                1 Reply Last reply
                0
                • mzimmersM Offline
                  mzimmersM Offline
                  mzimmers
                  wrote on last edited by
                  #70

                  OK, fixed that...but I'm still having the same problem as described above: I hit "yes" and...it continues on its way. Only after the workerThread gets to the end of the file, is requestFinish() called.

                  Maybe I'm not understanding how this should work -- once the requestWorkerToFinish signal is sent, the corresponding slot should execute immediately, right? So, my worker loop should terminate very quickly. That's what I was expecting, anyway.

                  1 Reply Last reply
                  0
                  • G Offline
                    G Offline
                    goetz
                    wrote on last edited by
                    #71

                    Sorry, I didn't have the time yet to prepare a test case. It'll last some more time...

                    http://www.catb.org/~esr/faqs/smart-questions.html

                    1 Reply Last reply
                    0
                    • mzimmersM Offline
                      mzimmersM Offline
                      mzimmers
                      wrote on last edited by
                      #72

                      No sweat, Volker...I appreciate your help. Would you like a fresh copy of the source code? Mine should be about the same as yours, but...you never know.

                      1 Reply Last reply
                      0

                      • Login

                      • Login or register to search.
                      • First post
                        Last post
                      0
                      • Categories
                      • Recent
                      • Tags
                      • Popular
                      • Users
                      • Groups
                      • Search
                      • Get Qt Extensions
                      • Unsolved