Implementing QAbstractTableModel

giesbert

Hi portoise,

could you post some minimal example so we can just debug the problem?
That would make it easier. Or did you try to debug on your own?
What is really returned in rowCount / columnCount/ flags etc.?

andre

I really don't like your design at all. Please considder "my docnote":http://developer.qt.nokia.com/doc/qt-4.7/model-view-programming.html#note-13 on designing your own QAbstractItemModels.

I think you first need to define a data store object that handles your blob of data, and supplies a sane API to query it. Only then, you create a QAbstractItemModel (or QAbstractTableModel, in your case) that works on top of that data store. The model is only used as an interface between the Qt item views and your internal data store. It is not suitable as a general data store, I think. The data itself should not be contained within the model.

dmcr

Still in myTable::setValues(QByteArray &values) you use QByte Array.

portoist

Here is link to my project on dropbox: "Test":http://dl.dropbox.com/u/44811245/Test.tar.gz
It reads data from text file specified in constructor of DeviceControll class. Data in file should be in following format: "dataId : rowCount colCount values", values should be separated by space. ie: "myMatrix: 2 2 1 2 3 4".

Andre, thanks for your reply and link to your docnote. It explained a lot to me, now i get how model should be used and next time i will stick to that!;-)

This "project" is just my playground and I'v followed example that I'v linked above.

giesbert

hi portoist,
I found one point:

@
QVariant myTable::data(const QModelIndex &index, int role) const
{
if (role != valueRole){
return QVariant();
}
...
}
@

this should not be, as you return for each role other than value role.
Try this code for the model data function:

@
QVariant myTable::data(const QModelIndex &index, int role) const
{
if(index.isValid())
{
cout<<"Data called with column:"<<index.column()<<" row:"<<index.row()<<endl;
if(Qt::DisplayRole == role)
{
if (this->m_data.count() <= 0){
return QVariant();
}
QList<QString> tmpLists = this->m_data[index.row()];
QString s = tmpLists[index.column()];
cout << "Data will return: "<<s.toLocal8Bit().data()<<endl;
return s;
}
}
return QAbstractTableModel::data(index, role);
}
@

portoist

Hmm thanks, i'v missed that! But:
@
return QAbstractTableModel::data(index, role);
@
will not work as it is virtual method.

andre

Indeed, it is pure virtual (normal virtual methods would work, of course). I guess this was just a matter of habbit from Gerolf to call base implementations as the default case; and a good habbit that is too! :-)

giesbert

[quote author="Andre" date="1318239693"]Indeed, it is pure virtual (normal virtual methods would work, of course). I guess this was just a matter of habbit from Gerolf to call base implementations as the default case; and a good habbit that is too! :-)[/quote]

aeh, yep, I did not test it otherwise I would have seen that :-) sorry.
a return of an empty variant should be it.

portoist

Well, it still doesn't solve my problem :-) How can I tell to the view that data are invalid? When I am using just simple List, I just call beginInsertRows and endInsertRows. It works ok and data method is requested for row 0,1,2.
I have tried calling beginResetModel each time before values are set but all it does is that it calls data method once with index of column 0 and row 0.
I gues I will have to use just simple list of QString and return whole rows in data method...

giesbert

In genereal, it works with beginResetModel / endResetModel if you change the whole model.
If you update a value, use dataChanged signal.
If you only insert a row or a column, use beginInsertRows() and endInsertRows, resp. Columns.