A few design questions...
-
Hey, Zap -
Thanks a ton for all this work. I will have more questions soon, I'm sure, but right now...I don't see how to go about editing the .qrc file. I've created it, but it won't let me put anything in it. Advice?
Thanks again.
EDIT:
I might as well mention some build errors:
@ view->rootContext()->setContextProperty("soc", soc);@
is giving this:
bq. error: invalid use of incomplete type 'struct QDeclarativeContext'
soc is an instance of my Soc class; I've been using that instead of the m_generator variable. Did I mess this up?
I'm getting a similar error for QKeyEvent.
Thanks...
-
Ah sorry I realised as I was going to sleep last night that I missed a trivial but important aspect to get this to build - you need to edit the .pro file so that it includes the line:
@QT += core gui declarative@
and re-run qmake. This will then tell qmake to add directives to the Makefile to allow the compiler and linker to find the QtDeclarative headers and libraries. Sorry about that.
To edit the .qrc file, just click on it in qt-creator. This will open it in the resource editor. Click on the "Add" button and choose "Add prefix". Then edit the prefix to "/" in the line edit below. Then click on "Add"->"Add Files..." and in the file dialog choose your .qml file. That's it. Your .qml file will now get compiled into your application.
Don't forget to add:
@
#include <QDeclarativeContext>
#include <QKeyEvent>
@in your .cpp file.
-
To make things easier I have uploaded a tarball of the example to my "webserver":http://www.theharmers.co.uk/simpletest.tar.gz. Just download it, unpack it and run qmake && make.
-
I'm still getting one compiler error, and as fate would have it, it's on the line you described above as "very important."
First, a bit of context may be helpful. Here's the private section of my Widget class:
@private:
Ui::Widget *ui;
QTimer *m_timer;
Soc *soc;@So, soc is what I'm using instead of m_generator. It's the top-level class/data structure in my program.
In widget.cpp, this line is giving me an error:
@ view->rootContext()->setContextProperty("soc", soc);@
[quote]error: invalid use of incomplete type 'struct QDeclarativeContext'
/Library/Frameworks/QtDeclarative.framework/Versions/4/Headers/qdeclarativeview.h:59: error: forward declaration of 'struct QDeclarativeContext[/quote]What did I do wrong? Thanks.
-
[quote author="ZapB" date="1302014795"]Sounds like you missed the line:
@#include <QDeclarativeContext>@[/quote]
Awcrud. You're right. So, do I still need both QDeclarativeView, or does QDeclarativeContext include that for me?
By the way, I followed your instructions on the creation of the .qrc file. I think it worked OK, but it doesn't look like your example above. It just has two lines: the slash and the filename. Not sure if that's a problem.
Thanks!
-
My example only used:
@#include <QDeclarativeContext>@
The header for the view is included by the generated ui code.
Wrt to the qrc file, I am not sure. Try it and see what happens ;-) If the worst happens just download my entire example from "here":http://www.theharmers.co.uk/simpletest.tar.gz
-
Seems to work fine.
I just realized that I'd chosen the wrong variable(s) to display via the GUI. This will give me a good chance to see whether I understand this stuff enough to correctly change the program. Once I get this fixed, I'll report back, and we can talk about the next step, if that's OK with you.
EDIT:
Something I've been meaning to ask: what's the purpose of the convention of naming object elements with the "m_" prefix?
-
The "m_" prefix is a subset of Hungarian notation that I choose to use as it helps me distinguish between local and member variables. I also use "ms_" prefix for static member variables. I do not bother encoding the type into the variable name as is done with full Hungarian notation though.
It's just a question of style. Other people will use different conventions.
What is your next step that you want to achieve?
Edit: NB Qt does not use Hungarian notation in its code base.
-
So, I've gone through my various files, changing that variable name. The program compiles OK, but on launch, I get a message:
bq. Object::connect: No such signal Soc::shaperOutIChanged(int) in ../simulatorGUI/src/widget.cpp:18
shaperOutIChanged used to be combGainIChanged...I believe you told me this was automatically generated. Any idea what I did wrong here? I can post code if you want.
Thanks.
Oh, as far as next steps: we could go one of two ways:
- add some control buttons for start/stop/step
- make the display a little more "graphic" (once it works)...maybe using the LCD display widget if that's possible?
-
The implementation of signals is done for you but your still need to declare them in the signals: section of your class. The notifier signal does not have any arguments. It is simply a signal to tell the world that the property has changed.
Can you post your header file for the Soc class please?
Before we can go to the next step you need to decide how you wish to construct your GUI:
QWidget based only.
QML only.
Mixture of QWidget (e.g. for file menu, tool bars) and QML (perhaps for the main visualisation part).
You could also choose to use QGraphicsView in place of QML and a QDeclarativeView.
The choice is yours. You have seen examples of how to connect up QWidget-derived GUI elements and QML items to your C++ computational object's properties. Let us know which route you wish to follow and we'll see what we can do.
If I were in your position I would be tempted by option 3, but that's just me. Options 1 and 2 are equally valid.
-
Here's my soc.h file (with some unessential stuff removed):
@#ifndef SOC_H
#define SOC_H#include <QObject>
class Soc : public QObject
{
Q_OBJECT
Q_PROPERTY (int shaperOutI
READ getShaperOutI WRITE setShaperOutI NOTIFY shaperOutIChanged)public:
explicit Soc(QObject *parent = 0);
int getShaperOutI() const;
void setShaperOutI(int i);public slots:
void runOneCycle();signals:
void shaperOutIChanged ();private:
DemodShaperFilter filter; // one shaper filter for now
SystolicFilter sf;};
#endif // SOC_H
@--
Before I decide on which option to go, I'd like to get this cleaned up. I'm probably just going to go with 2 or 3, though.
Thanks.
-
Update: I reread your post above, and discovered that I'd missed the part about no arguments to the notifier signal. That got me halfway home. The other problem was in my .qml file, specifically this line:
@ onShaperOutIChanged: {
@I had put a small "s" on shaper, since that's the precise (non)capitalization of the routine name, but it didn't like that. (The error message scrolled past too quickly for me to notice at first.) Replacing it with a capital "S" makes it work...but I don't understand why. If you could shed some light on this, that would be great.
Now that it's working, I'd like to start playing with the formatting of the display. Is this typically done in design mode, or just by editing the QML file? I'd like to change the size of the inner rectangle, the color(s) of the background, text placement, that kind of stuff. Probably through Design mode, right?
-
You connect statement does not match the signature of your signal. The error message you posted implies that you used an int as an argument in the connect but your header file shows the signal has no arguments (as indeed it should not).
Change your connect statement that hooks up to the shaperOutIChanged() signal to have no mention of an int argument.
-
[quote author="mzimmers" date="1302051296"]Update: I reread your post above, and discovered that I'd missed the part about no arguments to the notifier signal. That got me halfway home. The other problem was in my .qml file, specifically this line:
@ onShaperOutIChanged: {
@I had put a small "s" on shaper, since that's the precise (non)capitalization of the routine name, but it didn't like that. (The error message scrolled past too quickly for me to notice at first.) Replacing it with a capital "S" makes it work...but I don't understand why. If you could shed some light on this, that would be great.
[/quote]
That's how Quick works: it automatically creates a camelcase name for the signal.[quote]Now that it's working, I'd like to start playing with the formatting of the display. Is this typically done in design mode, or just by editing the QML file? I'd like to change the size of the inner rectangle, the color(s) of the background, text placement, that kind of stuff. Probably through Design mode, right?[/quote]
There is no established practice for that. QML is too new, and the designer is very new too. Do whatever feels right to you: modify your design in "code" (QML) or visually.
