Exception Handling, Throwing Exception and Try/Catch blocks
-
[quote author="Bradley" date="1292100479"]Qt is exception safe for the most part. Here is some "documentation":http://doc.trolltech.com/4.7-snapshot/exceptionsafety.html [/quote]
Oh that's bad :( - I mean it's clear, that I have to care for pointers myself, but if automatic objects (=variables declared per value on the stack) crash, than I should rethink thoroughly my idea of combining exceptions with Qt. -
-
My question though revolves around implementing custom handlers. In the example code that I copied into the original post there is a situation where a NULL pointer could be returned which would cause the AddEdge to fail. In the case of the code above the failure is silent (i.e. nothing happens).
However, I would like to have the function raise an error message so that program can let me know that there was error and then exit - I hope - gracefully.
Based on what I've been reading, I have two choices: Writing my own Exception Handlers or using Qt native error numbers. is that correct?
I haven't really found anything in the Qt documentation that discusses implementing custom error handling (i.e. trapping NULLs, DIV/0, Bad Memory Allocations, etc.). Is there material out there that discusses the creation of custom error handling?
Hopefully, I'm not making this harder than it should be.
-
Qt is not using error numbers in all cases, some functions just tell success / fail (True / false). "QFie":http://doc.qt.nokia.com/4.7/qfile.html uses error numbers "QFile::error()":http://doc.qt.nokia.com/4.7/qfile.html#error for example.
And take care: Exception handling catches custom exceptions, no structured exception like null pointer access, division by 0 etc.
That can be handled by structured exception handling (windows) or signal handlers (Linux). -
cazador7907, I think in the case of your Graph::AddEdge method, returning a bool would be much better. It was also possible to use two GraphNode& parameters and resolve the names before you call the method. Then the problem - if any at all - will be outside the method (as you wished).
If you insist in doing it the exceptional way, you have to classify the errors in your application first.
Error handling is always hard. If you decide to use exception handling, you have to be more consistent in comparison to error codes: the ignore-option isn't available when exceptions are thrown.
-
cazador, there is no such thing like "Qt native error numbers". You will have to define them yourself, probably as an enum in a class or namespace of your application.
As the others already said, alternatively, you can also use exceptions for your own error handling.
If you go with error numbers or exceptions is to a certain degree a matter of taste. But there are some reasons, that favor exceptions (e.g. the "C++ FAQ on exceptions":http://www.parashift.com/c++-faq-lite/exceptions.html, it lists some cases, that are difficult to handle with error numbers, but easy with exceptions). I successfully integrated another lib, that uses exceptions for error handling with Qt (ImageMagick/GraphicsMagick, if you care).
The reason why Qt does not use exceptions is more or less historical. You have to know that the very first implementation was made over 12 years ago. At that time compilers supporting exceptions were not very common. This holds true for the 3.x series too, that was initially released in 2001. I think even the 4.x series was supposed to build with compilers in 2005 that did not yet support exceptions. I would not bet, that they ignore exceptions for the 5.x series too :-)
-
How do I define my own error number? I might have missed it in my searches but I cannot find any guidance in the Qt documentation.
-
[quote author="cazador7907" date="1292202586"]How do I define my own error number? I might have missed it in my searches but I cannot find any guidance in the Qt documentation.[/quote]
If you are not familiar with error numbers:@
/// this is a enumeration of all error conditions "I currently know"
enum MyRunTimeErrors {
MY_SUCCESS_CODE,
MY_INDEX_OUT_OF_BOUNDS,
MY_NULL_POINTER_NOT_ALLOWED,
MY_INVALID_RANGE
};/// this is a placeholder function handling all "currently known" errors
void test() {
const int error = doSomethingNonTrivial(); // in this call several errors can occur
switch (error) {
code MY_SUCCESS_CODE:
// All went good :)
// Make anything else here...
break;code MY_INDEX_OUT_OF_BOUNDS: // Handle index not inside the valid bounds of an array (a list) break; code MY_NULL_POINTER_NOT_ALLOWED: // Handle unsuported null pointer break; code MY_INVALID_RANGE: // Handle numeric range miss, maybe by an input break; default: // Oops, who (me ??) did something wrong, and especially: WHAT? traceError("Internal Error: Unknown Error detected #%d", error); break;}
}
@..., leave this out, study exception handling today!
The exception-based way is much better, since you can group error conditions and decide from case to case how specific your handling should be. You get a second channel for error detection, error transmission, error handling. Exceptions are not used yet in Qt, but (my glass ball says:) it will (it has to) come that we can switch them on optionally.
-
Hi Wolf, exceptions or not is a matter of taste, as Volker said. I suggest using error number more than exceptions. If you want to ignore the error, that's easy with error numbers not with exceptions. If the exceptions are not 100% cleard efined in the throws, it's hgard to know, which exceptions are thrown and should be catched. And in many places, where exceptions are used for errors, I see only this:
@
try
{
// do some stuff that might throw an exception
}
catch(...)
{
// do something
}
@And then, exceptions do NOT make sense.
-
When you find this style of exception handling "used" everywhere in your project
@
catch (...) { /* indeed: do NOTHING */ }
@
...then it's a sure sign of ignorance. I think those, who try to skip analysis, understanding and classification of errors, will never succeed in error handling. Skipping default in switch is equivalent to catch all clauses anywhere in the code.Of course, you can classify errors using numeric codes. But that's hard work.
-
Wolf P., again it's just matter of taste. For me errno way is much simplier error handling than exception-way.
-
That I have to accept.
Here something more interesting, I've found googling for "Qt exception exec":
"Qt: Throw exceptions from signals and slots":http://rohieb.wordpress.com/2010/07/08/qt-throw-exceptions-from-signals-and-slots/
For those who like exceptions it may be interesting ,if not already known.