Send a text to textEdit from a non qt cpp file

saeid0034

@JonB
I know I cant explain my problem right and im sorry about that
the only thing I want is send a text from a cpp file that include my codes to mainwindow ui
I tried this, but its wont work
in CreateRemoteThread_Type1 header

#pragma once

#include <QObject>

class CreateRemoteThread_c: public QObject
{
	Q_OBJECT

public:
	CreateRemoteThread_c(QObject *parent = Q_NULLPTR);
	void SendMSG(int error, QString str_2, QString str);

signals:
	void updateUI(int error, QString str_2, QString str);
};

in in CreateRemoteThread_Type1 cpp file

#include "Injector.h"
#include "CreateRemoteThread_Type1.h"

CreateRemoteThread_c::CreateRemoteThread_c(QObject *parent)
	: QObject(parent)
{
}

void CreateRemoteThread_c::SendMSG(int error, QString str_2, QString str)
{
	emit updateUI(error, str_2, str);
}

bool CreateRemoteThread_Type1(LPCSTR ID, HANDLE hProcess)
{
	CreateRemoteThread_c Sender;
	Sender.SendMSG(0, "string", "string 2");

}

and after that I include CreateRemoteThread_Type1.h in my mainwindow header
also Im created a slot in mainwindow header and created it in cpp file too

private slots:
    void AppendToTextEdit(int error, QString str_2, QString str);

then connect updateUI signal to AppendToTextEdit slot in mainwindow::mainwindow(QWidget *parent) in my mainwindow.cpp

CreateRemoteThread_c* MsgSender = new CreateRemoteThread_c;

	QObject::connect(MsgSender, &CreateRemoteThread_c::updateUI, this, &mainwindow::AppendToTextEdit);

but slot never called
sorry for long text, can you please tell me what is my problem?

JonB

@saeid0034
Glancing through your code, it looks reasonable. As ever, while developing use qDebug() messages to verify your signal is being emitted, received etc.

saeid0034

@JonB said in Send a text to textEdit from a non qt cpp file:

Glancing through your code, it looks reasonable.

as you said I check the code with qDebug()
SendMSG function called but seems like signal doesn't emit
I dont know what is my problem
edit
yes, I tested connect with lambda and tried to show a massage when signal received, but nothing happened.

JonB

@saeid0034
Look, I'm not sure [actually, I am sure], but: in CreateRemoteThread_Type1 you have a CreateRemoteThread_c Sender; local variable which is the signal sender. Meanwhile in the connect() you have a new CreateRemoteThread_c object, MsgSender. What is going on here? The connection must be from the object which sends the signal, and I think you have two completely separate objects here??

saeid0034

@JonB
oh, yes you right, but one question how can I use one object for both mainwindow and CreateRemoteThread_Type1?

JonB

@saeid0034
I knew you were going to ask that next! :) I'm afraid, that's your problem! I don't know enough about how your CreateRemoteThread_c code/object(s) fit together with your main window code. Do you create CreateRemoteThread_c instances more than once? If there really is only one you could use a singleton pattern. Or, main window can create it, I don't know what your non-class function CreateRemoteThread_Type1 is about, why you needed that.

Only you know how your code relates. Whatever, the instance that does the emit of the signal must be the same instance as main window specifies in its connect() statement, that is what is vital.

saeid0034

@JonB said in Send a text to textEdit from a non qt cpp file:

@saeid0034
I knew you were going to ask that next! :) I'm afraid, that's your problem! I don't know enough about how your CreateRemoteThread_c code/object(s) fit together with your main window code. Do you create CreateRemoteThread_c instances more than once? If there really is only one you could use a singleton pattern. Or, main window can create it, I don't know what your non-class function CreateRemoteThread_Type1 is about, why you needed that.

Only you know how your code relates. Whatever, the instance that does the emit of the signal must be the same instance as main window specifies in its connect() statement, that is what is vital.

thank you for all your help and Sorry for bother you so much
at the end I think my best solution is change my code, one last question😅
you think if I include all my needed function from CreateRemoteThread_Type1 and SetPrivilege in my mainwindow code its okay?

JonB

@saeid0034 said in Send a text to textEdit from a non qt cpp file:

you think if I include all my needed function from CreateRemoteThread_Type1 and SetPrivilege in my mainwindow code its okay?

This is not ideal! You really want to keep separation between a Qt main window/program and some piece of Windows-specific code to do goodness what. Try to make a self-contained class out of what you have with this code. But this is a general programming issue.

JoeCFD

send out your text via standard output std::cout in your cpp code and catch it in Qt code.
https://forum.qt.io/topic/80024/how-to-redirect-output-of-stdout-to-gui-qtextedit-shell-from-one-process-to-another-process/2

saeid0034

I manage to fix it wait add in function deceleration from worker.h to mainwindow.h
know I can send signal and receive it
I'm still don't know if its a good way to do this...

saeid0034

one other thing
know I can access ui from all c++ file I declared in header
its bad? and why?

saeid0034

@JonB
Hi, I worked with it a little more and I come up with this codes

worker.h

class Worker : public QObject
{
	Q_OBJECT

public:
	bool GetOSInfo();
	bool SetPrivilege(HANDLE hToken, LPCTSTR Privilege, BOOL bEnablePrivilege);
	void DisplayError(LPCSTR szAPI);
	int EscalatePrivilege();
	bool CreateRemoteThread_Type1(LPCSTR ID, HANDLE hProcess);

signals:
	void updateUI(const int error, const QString text, const QString value);

};

CreateRemoteThread.cpp

bool Worker::CreateRemoteThread_Type1(LPCSTR ID, HANDLE hProcess) {
//some code
	emit updateUI(0, "text", Null);
}

mainwindow.h

private slots:
    void Reciver(const int error, const QString text, const QString value);

and mainwindow.cpp

Worker worker; //global

Mainwindow::Mainwindow(QWidget *parent)
    : QMainWindow(parent)
{
    ui.setupUi(this);
		
	QObject::connect(&worker, &Worker::updateUI, this, &mainwindow::Reciver);
}

//some code

void mainwindow::Reciver(const int error, const QString text, const QString value)
{
	ui.textEdit->append(text);
}

its working and slot Trigger when signal fired
I only want to know there is any better way then declare Worker globally in mainwindow? (i declare it globally because I need it some other function other then main)
and one other thing, after all this code ideal?

thanks for all your helps and sorry for bothering you so many times