qtreeview item text too long

[user4592357]

@SGaist
sorry but i cannot write an example that shows the behavior.
but in my actual code i have a tree view two modes.
when i have this structure:

"small text"
|__"long text"

the row heights are okay. but when i have

"long text"
|__"short text"

both rows have the height of three normal rows (i've set setUniformRowHeights(true), when i remove it, only first row is tall).

[VRonin]

Summoning @Christian-Ehrlicher as I think this one is a bug he sqashed

[Christian Ehrlicher]

@VRonin: According from the description it could be but we can't check... so @user4592357 either post some code to reproduce the problem or test with 5.12.3

[user4592357]

i finally understood what the problem is. my item had newlines in it.
but if i remove the newlines in my items then i will have two problems:

1. for every item i'll have to do it
2. i'm using these node texts in sql queries. so when i removed the newlines, the text didn't match the text in the database.
   what can i do here?

[VRonin]

class NoNewLinesDelegate : public QStyledItemDelegate {
    Q_OBJECT
    Q_DISABLE_COPY(NoNewLinesDelegate)
public:
    QString displayText(const QVariant &value, const QLocale &locale) const Q_DECL_OVERRIDE
    {
        QString baseText = QStyledItemDelegate::displayText(value, locale);
        return baseText.replace(m_newLineRegExp,QStringLiteral(" "));
    }
    explicit NoNewLinesDelegate(QObject* parent = Q_NULLPTR)
        : QStyledItemDelegate(parent)
        , m_newLineRegExp(QStringLiteral("[\r\n]+"))
    {}
private:
    const QRegularExpression m_newLineRegExp;
};

Now you just need to call treeView->setItemDelegate(new NoNewLinesDelegate(treeView));

[user4592357]

@VRonin
thanks but actually my bigger concern was the problem #2

[VRonin]

Yes, the point of my solution is that you don't have to change the data at all, you just change how the data is displayed.
Leave the newlines in the model and implement the solution above

[user4592357]

@VRonin
yes i just realized it's the displayText() method. thank you. and also can you please format the code so it's better readable? :)

[user4592357]

@VRonin
i tried to set this delegate to my tree view but the items are still displayed as before. in displayText(), i printed both before and after versions of text, and they're correct. i think the reason it's still the same is that the text is too long (200 chars)?

[JonB]

@user4592357
So if it is indeed the case that the text is too long for display, amend @VRonin's code which currently removes any newline to also limit the output to whatever length you consider acceptable.

[user4592357]

@JonB
i can't, because what if the column is resized to view the whole text?

[JonB]

@user4592357
I don't know, have you tried it? Does the resize for text not respect your shortened text returned from displayText()?