QNetwork doesn't work

[shaan7]

@JonB why are you assuming he is not running an event loop?

[JonB]

@shaan7
I am not assuming he is not running an event loop, you can see what I've written, all I have said is: is he running an event loop? And suggested an error slot also just in case.

[El3ctroGh0st]

@JonB I'm not quite sure what exactly I'm supposed to add, though. :( This is literally all I have:

WeatherGetter::WeatherGetter(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::WeatherGetter)
{
    ui->setupUi(this);

    WeatherReader wReader;
    wReader.getWeatherInfo("Paris");
}

Obviously I'll add things later on, but not right now.

[shaan7]

@El3ctroGh0st can you paste your main.cpp?

[El3ctroGh0st]

@shaan7

#include "weathergetter.hpp"
#include <QApplication>

int main(int argc, char *argv[])
{
    QApplication a(argc, argv);
    WeatherGetter w;
    w.show();

    return a.exec();
}

[JonB]

@El3ctroGh0st
Your WeatherReader wReader goes out of scope at end of WeatherGetter(), presumably taking the slot with it?

[shaan7]

@El3ctroGh0st @JonB is right, you should do this instead-

WeatherGetter::WeatherGetter(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::WeatherGetter)
{
    ui->setupUi(this);

    WeatherReader *wReader = new WeatherReader(this);
    wReader->getWeatherInfo("Paris");
}

or add a mwReader as a private member variable of the WeatherGetter class and use that.

[El3ctroGh0st]

@shaan7 Ahh yes, now it seems to reach the checkpoint. Thanks! I'm wondering though, what is the difference here between making it a pointer and now? Does making it a pointer prevent it from being deleted after going out of scope?

[shaan7]

@El3ctroGh0st said in QNetwork doesn't work:

Does making it a pointer prevent it from being deleted after going out of scope?

Yes. And passing this as a parent when using new makes sure that your WeatherReader will be deleted when WeatherGetter is deleted. See http://doc.qt.io/qt-5/objecttrees.html

[JonB]

@El3ctroGh0st

making it a pointer prevent it from being deleted after going out of scope?

Sure! You doing a new means you are responsible for doing a delete at some point, else it leaks. Local variable like you have now disappears when the function it's in exits; or make it a class member variable to keep it alive throughout the instance life-time.

[El3ctroGh0st]

Got it. Thanks to you two!