painter.drawline() , overlapping opacity problems with 100% opaque pen.

[Goffer]

So I ve tried to turn off all the anitialiasing setting that I have + added the "DontAdjustForAntialiasing"

self.setOptimizationFlag(QtWidgets.QGraphicsView.DontAdjustForAntialiasing)

self.setRenderHint(QtGui.QPainter.Antialiasing, False)
self.setRenderHint(QtGui.QPainter.TextAntialiasing, True)
self.setRenderHint(QtGui.QPainter.HighQualityAntialiasing, False)
self.setRenderHint(QtGui.QPainter.SmoothPixmapTransform, True)
self.setRenderHint(QtGui.QPainter.NonCosmeticDefaultPen, True)
self.setViewportUpdateMode(QtWidgets.QGraphicsView.FullViewportUpdate)

I ve also tried

self.setRenderHint(QtGui.QPainter.NonCosmeticDefaultPen, False)

But I still have the same issue ... looks like it might not be aliasing related.

[kenchan]

hmm... It might be helpful to see a screen shot of the results you are seeing.

[Goffer]

As you can see we see it on the small one but not on the zoomed in one.

[kenchan]

Yes, i can see what you mean about the smaller scale image. Just as a matter of interest, what does the smaller one look like when you zoom the pixels of your screen to the extent that you can see each pixel clearly?
As opposed to zooming it with the graphics view.

[Goffer]

What do you mean ? When it's at scale 1:1 ?
The problem occurs as soon as on my screen it becomes less than 1 px

[kenchan]

Sorry, I guessed you might not get what I meant.
What I meant was it would be nice to see an enlarged screen shot of your 1:1 display of it. i.e. can you apply a magnifying glass to the small image on your screen so one can see what the actual pixels look like?

[Goffer]

this one is 400%

[kenchan]

Thank you.
Well, I can see evidence of antialiasing on the line ends and the circles even though you have turned the antialiasing features off. I expect to see them on the text because you left the text antialiasing settings on. Horizontal lines look darker (more transparent?) and corners look lighter because they are drawn twice. Am I seeing this correctly?

So, either your antialias settings are getting changed at the last moment or your display device has a hardware antialiasing capability or it is actually getting that way due to windows scaling??

Other than that I am out of ideas. I use the graphics view in a similar fashion with the same settings as you and do not see that kind of thing. However, I do see exactly that kind of thing when I turn antialiasing on (the user can switch it on and off in my application).

[Goffer]

My bad, this screenshot has the antialiasing on. Will do it again tomorrow with antialiasing off.

They can turn it too in mine but i feel like it shouldn't happen even with antialiasing on

[kenchan]

OK.
If you have issues with how the antialiasing is implemented I suggest you send your questions to the interest mailing list here and try to catch the eye of a developer who knows about the details.

[Goffer]

self.setOptimizationFlag(QtWidgets.QGraphicsView.DontAdjustForAntialiasing)

self.setRenderHint(QtGui.QPainter.Antialiasing, False)
self.setRenderHint(QtGui.QPainter.TextAntialiasing, False)
self.setRenderHint(QtGui.QPainter.HighQualityAntialiasing, False)
self.setRenderHint(QtGui.QPainter.SmoothPixmapTransform, True)
self.setRenderHint(QtGui.QPainter.NonCosmeticDefaultPen, False)
self.setViewportUpdateMode(QtWidgets.QGraphicsView.FullViewportUpdate)

even with those settings, that's what I get

This is not antialiasing related. Somehow lines get some opacity.

[kenchan]

Well that is strange isn't it.
Maybe you could put the code that draws that into a minimal example app so we can all try to reproduce it.

[Goffer]

Okay, I wrote a quick example with the same view settings.
It looks fine at scale 1 and same problem when zooming out.

from PySide2 import QtGui, QtCore, QtWidgets

class TestView(QtWidgets.QGraphicsView):

    def __init__(self, parent=None):
        super(TestView, self).__init__(parent)

        self.setOptimizationFlag(QtWidgets.QGraphicsView.DontAdjustForAntialiasing)
        self.setRenderHint(QtGui.QPainter.Antialiasing, False)
        self.setRenderHint(QtGui.QPainter.HighQualityAntialiasing, False)
        self.setRenderHint(QtGui.QPainter.NonCosmeticDefaultPen, False)
        self.setViewportUpdateMode(QtWidgets.QGraphicsView.FullViewportUpdate)
        self.setTransformationAnchor(QtWidgets.QGraphicsView.AnchorUnderMouse)
        self.setHorizontalScrollBarPolicy(QtCore.Qt.ScrollBarAlwaysOff)
        self.setVerticalScrollBarPolicy(QtCore.Qt.ScrollBarAlwaysOff)

    def wheelEvent(self, event):
        self.setTransformationAnchor(QtWidgets.QGraphicsView.AnchorUnderMouse)

        inFactor = 1.15
        outFactor = 1 / inFactor

        if event.delta() > 0:
            zoomFactor = inFactor
        else:
            zoomFactor = outFactor

        self.scale(zoomFactor, zoomFactor)

class TestItem(QtWidgets.QGraphicsItem):

    def __init__(self):
        super(TestItem, self).__init__()

    def boundingRect(self):
        return QtCore.QRect(0, 0, 200, 400)

    def shape(self):
        path = QtGui.QPainterPath()
        path.addRect(self.boundingRect())
        return path

    def paint(self, painter, option, widget):
        brush = QtGui.QBrush(QtGui.QColor(70, 70, 70, 255))
        painter.setBrush(brush)

        painter.drawRoundedRect(0, 0, 200, 400, 20, 20)

        pen = QtGui.QPen(QtGui.QColor(200, 200, 200, 255))
        pen.setWidth(1)
        painter.setPen(pen)

        painter.drawLine(50, 50, 50, 300)
        painter.drawLine(50, 80, 50, 200)
        painter.drawLine(50, 80, 150, 80)


view = TestView()
scene = QtWidgets.QGraphicsScene()
view.setScene(scene)

item = TestItem()
scene.addItem(item)
    
view.show()

[kenchan]

Great, i will give it a try when I can make a bit of time :-)

[kenchan]

BTW, I don't use python so I will be testing it with C++. Someone else might pitch in and try it with python for you.

[kenchan]

So which Version of Qt are you using for this? I assume you are using Windows right?

[Goffer]

I'm using Qt5 I think it's 5.6.1 and yes I'm on windows, will give it a try on MacOS
I've tried in Qt 4.8.2 and it's exactly the same

[kenchan]

Hello @Goffer. I made a test app with a QGraphicsView using the same settings as you here are the results so far.
Note: i did not bother to sub class a graphics item yet as I don't think it makes a difference.
I don't see those artifacts at 1:1 zoom scale.
zoom scale 1.0

I do see those artifacts at less than a 1:1 zoom scale. I guess this is because the line thickness of on device pixel is now trying to show line a less than one physical device pixel width?? I think this is what the paint engine does when the device to logical pixels don't match, but I am no expert on that. You need to discuss those details with the developers.
zoom scale 0.5

I used Qt 5.8.0
This is on macOS High Sierra 10.13
I will try it on Windows later and let you know the results.

Hope that helps :-)

[kenchan]

Sorry but my images links are not showing up?? you will have to click on the links to see them I guess :-)

[Goffer]

I've tried to make the pen cosmetic by setting the width to 0. That way the line should always have the same width on screen no matter the zoom factor. And the problem still occurs.