QNetworkAccessManager doesn't emit finished without blocking current thread

Xander84

Why do you use your own QEventLoop anyways? Don't you have a QCoreApplication running in your program?

blokant

I have typical main.cpp in my project
@
int main(int argc, char *argv[])
{
QApplication a(argc, argv);
Dialog w;
w.show();
return a.exec();
}
@
And i have separate class, which use QNAM

Xander84

then you should not need a second QEventLoop (QApplication already has a QEventLoop internally), that might be the problem why your signals and slots are not working as they should.
The QApplication is usually a global object in your application, you can access it with the global pointer qApp from anywhere if you need to.

So it should not matter if you create the QNAM from your Dialog or in the main.cpp or whatever, you don't need to create a QEventLoop yourself for it to work.

blokant

well, then .. why it does not work properly? If i use my QEventloop i see that it freeze a little bit but it works

Chris Kawa

Hard to tell with the information you gave. Maybe you're deleting the receiving object before the finish signal fires? And since you put additional blocking exec() it works.
Some more context and code would be helpful.

blokant

@
QNetworkAccessManager *nwam = new QNetworkAccessManager();
QNetworkRequest request = new QNetworkRequest(QUrl(listUrl));
request->setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
nwam->get(request);
connect(nwam, SIGNAL(finished(QNetworkReply)) , this, SLOT(processTaskListsReply(QNetworkReply)) );

@
@
processTaskListsReply(QNetworkReply *r)
{
qDebug() << "processTaskListsReply();";
QByteArray ba = r->readAll();
qDebug() << ba;
}
@

Chris Kawa

I meant the context of it. Where is it created. What is the lifetime of the object it holds these. Where is the nwam deleted etc.

Xander84

it almost looks like you create a new QNetworkAccessManager for every request? hard to tell from your snippet but that is not a very good idea.

If you read the doc of QNAM it says one object per app should be sufficient in most cases, so usually you have one global QNAM and there is no need to create it on the heap (with new).

What I would do, if you onyl have one Dialog in your app then just create an object in there:
@
class Dialog : public QDialog
{
Q_OBJECT
private:
QNetworkAccessManager m_networkManager;
};
@
and then connect the signals of m_networkManager in the constructor of the Dialog only once and reuse the QNAM for all requests. Unless you only need the QNAM in rare cases this would be a better way I think.

blokant

ou, i see: i have to use only the one QNAM for all classes of my app. Thanks, i will try it later

Xander84

You don't have to use only one instance, but it would be considered best practice to only have one, because the QNAM initialization might be expensive and it also caches many things like DNS resolution etc, if you create a new one every time that cache will be lost and network requests take longer.
There was a nice talk about it, if you want take a look I found it very interesting. "QtDD13 - Peter Hartmann - Speeding up your Qt app with new QtNetwork features":https://www.youtube.com/watch?v=OM9BgcXr9ys&list=LLa69qk-_WIRna0JNQf8Md0w.

blokant

ou, thanks, i will try to watch all that videos if i will get time. I will use Singleton

blokant

Singleton may be not so good idea, i found this

@
DbHandler* dbHandler = new DbHandler;

// Make your DbHandler* globally accessible by settings it as a
// dynamic property of the application object.

application.setProperty("dbHandler", QVariant::fromValue<DbHandler*>(dbHandler));

....

}

void SomeObject::someMethod()
{
DbHandler* dbHandler = qApp->property("dbHandler").value<DbHandler*>();
}
@

But... what if i wand to split a part of my app as library later, then i will get dependency injection: users will have to give QNAM instance to my constructor, is it right way?

JKSH

[quote author="blokant" date="1396679021"]Singleton may be not so good idea[/quote]Why not?

[quote]But... what if i wand to split a part of my app as library later, then i will get dependency injection: users will have to give QNAM instance to my constructor, is it right way?[/quote]Your library should be the one that creates the QNAM. Users of your library shouldn't need to know that you are using a QNAM behind the scenes.