[Solved] Can I include extended ascii codes in my application?

mlong

I would put this functionality into its own method, then call the method from inside your loop.
@
char MyClass::convertCharacter(char val, char offset) { }
@
or something like that.

croussou

Got it, thank you!

mlong

No problem. The nice part is that you can then use that same method to convert back the other way by just using a negative offset.

_Edit to add: _

Also, I used chars, but you might want to use a temporary int (or short) variable for the calculations to reduce the possible effects of overflow, should the offset be too high or low.

croussou

My code now looks like this...

@
key = 20;
input_string = ui->lineEdit->text();

for(int i = 0; i &lt; input_string.length(); i++)
{
    random = input_string.at(i).toAscii();
    //result1.append(QChar(random).toAscii());

    if ((random) &gt;= 32 && (random) <= 176)
    {
        random -= 32;
        random += key;

        if (random < 0)
            random += 144;

        if (random > 144)
                random -= 144;

        random += 32;
    }

    result1.append(QChar(random).toAscii());
    ui->lineEdit_3->setText(result1);

@

It works when the key is small but it malfunctions when the key gets bigger, i.e. 20. When the key is big, it still provides an output, but when you try to select it, then it crashes...I guess there are some 'funny' characters that cannot be read...Because when I copy it and paste it somewhere else it displays this:

{y{y{

In addition, I noticed it malfunctions most of the time with letter 'z'...no clue.

croussou

Yes, anything equal or more than 5 causes a problem if the letter 'z' is used...

mlong

It would have helped if I had used the decimal value for ~ (126) rather than the octal value (0176).

So change all the 176s to 126, and change all the 144s to 94.

I edited my earlier example to reflect this correction.

mlong

The following works for me:

@

#include <QDebug>
#include <QString>

int main(int argc, char** argv)
{
int key = 20;

QString input_string;
for (int idx = ' '; idx <= '~'; idx++)
{
   input_string.append(QChar(idx));
}

qDebug() <&lt; input_string;

QString result1;

int random = 0;

for (int i = 0; i &lt; input_string.length(); i++)
{
    random = input_string.at(i).toAscii();

    if ((random) >= 32 && (random) <= 126)
    {
        random -= ' ';
        random += key;

        while (random < 0) random += 94;
        while (random > 94) random -= 94;

        random += ' ';
    }
    result1.append(QChar(random).toAscii());
} 

qDebug() << result1;

return 0;

}
@

croussou

Already done that and works perfectly. Tested up to key 20...do you think I can go further? or I would start getting crashes?

mlong

Change the two inner ifs to whiles, and then it should always keep your resultant strings within bounds (for instance if the offset were > 94).

As for crashes, see for yourself. And if you were to crash, it would be a good opportunity to practice debugging.

croussou

Seems good thank you.

For now, I will keep the key small and maybe later develop this further.

Anyhow, thanks again!

lgeyer

One small addition: as you know the length of the resulting string in advance you should reserve it using QString::reserve(). This will save, depending on the length of the string, a bunch of reallocations, which might or will have an impact on your performance, especially if the "transformation function" is called often.

croussou

Good suggestions indeed, but that function will not be called that often. Just once actually for the user to enter the message and get it 'encrypted'.

Thanks for the suggestion though.