Copying two files in a third one...

? This user is from outside of this forum

For text specifically, this should work:

@QString text1, text2;

QFile file1("c:/test1.txt");
QTextStream in1;
if (file1.open(QIODevice::ReadOnly))
{
in1.setDevice(&file1);
}

QFile file2("c:/test2.txt");
QTextStream in2;
if (file2.open(QIODevice::ReadOnly))
{
in2.setDevice(&file2);
}

in1 >> text1;
in2 >> text2;

QFile result("c:/result.txt");
QTextStream res;
if (result.open(QIODevice::WriteOnly))
{
res.setDevice(&result);
}

res << text1 << text2;@

It basically creates two strings, two input files, two text streams, inputs the text streams from the files into the strings, and finally outputs the strings into the third text stream which is the output file.

croussou

Thank you.

I get QTextStream::No device...

JohnKaul

[quote author="croussou" date="1329947758"]Both I guess, is it possible to combine?
Thank you.[/quote]

Why don't you start with "plain text" and move on from there.

Here is a very simple (aka: basic) example. This example doesnt use any Qt, only standard C++ stuff.
@
int main(int argc, const char *argv[])
{
std::string InFile("InputOneFileTest.txt");
std::fstream inputOne(InFile.c_str(), std::fstream::in);

std::string OutFile&#40;"OutputFileTest.txt"&#41;;
std::fstream output(OutFile.c_str(), std::fstream::out);

std::string str;
while (getline(inputOne, str))
    output << str << '\n';

InFile = "InputTwoFileTest.txt";
std::fstream inputTwo(InFile.c_str(), std::fstream::in);

while (getline(inputTwo, str))
    output << str << '\n';

return 0;

}
@

? This user is from outside of this forum

do you have the text1 and text2 files in your c:/ ?

you need to replace those with the files you actually want to combine

croussou

Nevermind, misspelled the file name, I think its getting late...

I have written something in text1 and something in text2...after execution result remains empty...

? This user is from outside of this forum

this is odd, it works for me, I had "123" and "456" in text1 and text2 respectively, and got "123456" in result.

Have you included QtCore and QFile?

ALso check if result is not open, also you may want to add:

@result.close();@

at the end to make sure your file doesn't stay open in which case the program will not be able to write in it

croussou

Here is the code...

@#include <QtCore/QCoreApplication>
#include <QFile>
#include <QTextStream>

int main(int argc, char *argv[])
{
QCoreApplication a(argc, argv);

QString text1, text2;

     QFile file1("/Users/croussou_dm4/Desktop/text1.txt");
     QTextStream in1;
     if (file1.open(QIODevice::ReadOnly))
     {
 in1.setDevice(&file1);
     }

     QFile file2("/Users/croussou_dm4/Desktop/text2.txt");
     QTextStream in2;
     if (file2.open(QIODevice::ReadOnly))
     {
 in2.setDevice(&file2);
     }

     QFile result("/Users/croussou_dm4/Desktop/result.txt");
     QTextStream res;
     if (result.open(QIODevice::WriteOnly))
     {
 res.setDevice(&result);
     }

     in1 >> text1;
     in2 >> text2;

     res << text1 << text2;

return a.exec(&#41;;

}
@

Text1 and Text2 are there, after I run the app the Result text file appears but empty... :S

? This user is from outside of this forum

Check my previous post, I edited it, maybe your result file stays open in which case the program will not write to it.

croussou

That's it, works perfectly now. Thanks a lot, both of you.

Now, can I do that with any type of file?

? This user is from outside of this forum

No responders, it seems like I will have to come to the rescue again. I hope I am not doing your homework ;)

This should work for all type of files as it does raw data copy:

@QDataStream in1, in2, out;
QFile file1("c:/test1.txt");
if (!file1.open(QIODevice::ReadOnly))
return EXIT_FAILURE;

in1.setDevice(&file1);

QFile file2("c:/test2.txt");
if (!file2.open(QIODevice::ReadOnly))
return EXIT_FAILURE;

in2.setDevice(&file2);

QFile result("c:/result.txt");
if (!result.open(QIODevice::WriteOnly))
return EXIT_FAILURE;

out.setDevice(&result);

char *data1 = new char[file1.size()];
char *data2 = new char[file2.size()];

in1.readRawData(data1, file1.size());
in2.readRawData(data2, file2.size());

out.writeRawData(data1, file1.size());
out.writeRawData(data2, file2.size());

result.close();

delete [] data1;
delete [] data2;@

To anyone more experienced, I am curious if there is a way to directly copy raw data from disk without using the dynamically allocated char[] to read in the two files. Thanks!

croussou

That code did the trick. I honestly appreciate your help, it was essential for proceeding with this project.

P.S This is an individual project for getting more familiar with Qt and file operations. Has nothing to do with school homework.

Again, thanks a bunch.

? This user is from outside of this forum

You are welcome, just note this implementation stores copies of both files in memory, so if you use it to merge really big files you might get very low performance or even an error.

andre

[quote author="ddriver" date="1329954109"]No responders, it seems like I will have to come to the rescue again. I hope I am not doing your homework ;)

This should work for all type of files as it does raw data copy:

@QDataStream in1, in2, out;
QFile file1("c:/test1.txt");
if (!file1.open(QIODevice::ReadOnly))
return EXIT_FAILURE;

in1.setDevice(&file1);

QFile file2("c:/test2.txt");
if (!file2.open(QIODevice::ReadOnly))
return EXIT_FAILURE;

in2.setDevice(&file2);

QFile result("c:/result.txt");
if (!result.open(QIODevice::WriteOnly))
return EXIT_FAILURE;

out.setDevice(&result);

char *data1 = new char[file1.size()];
char *data2 = new char[file2.size()];

in1.readRawData(data1, file1.size());
in2.readRawData(data2, file2.size());

out.writeRawData(data1, file1.size());
out.writeRawData(data2, file2.size());

result.close();

delete [] data1;
delete [] data2;@

To anyone more experienced, I am curious if there is a way to directly copy raw data from disk without using the dynamically allocated char[] to read in the two files. Thanks![/quote]

Yes, there is. It is never a good idea to just allocate a block of memory the size of a file you don't know. What if the file is 2GB, the other file is big as well? You'll run out of memory in no time flat. Instead, you read the file block by block, perhaps in blocks of 4KB or so. Note that Qt has a QByteArray class you can use for this purpose, instead of a raw char array.

Also, note that there really isn't a need to read in the first file at all. Simply copy the first file to the new file first (the OS can handle that more efficiently than you can), and then open the copy in append mode and add whatever is in the secons file to it.

Last, for croussou:

Note that if you concatenate binary files like this, the file is not likely to be valid any more. For instance, if you add two mp3 files together like this, the result will not be one mp3 file that just has both original songs, and combining two jpg images will not result in one bigger image that has both. There is no generic way to concatenate files in a meaningful way.

? This user is from outside of this forum

Yes that was what I had in mind last night but it was kind of late so I went with the "simpler" solution. BTW I already warned him about merging files that contain format headers, this is applicable ONLY for raw data.

For specific formats the concatenation must also be format specific, you must know how to parse that file, read in header tags and process them and only merge the raw data.

I was also thinking about pre-allocating the output file to the size of both inputs so that fragmentation can be avoided.

Since we are now talking BIG files, it would be wise to abort the operation early on in case there is not enough free space on disk, not merge the files all the way to 90% and fail just then, when time has been waster and the entire disk has been filled, which may have other negative implications.

croussou

What is a file with format headers?

I have tried some operations with .7z files and seems to work. The files I intend to concatenate are fairly small, so I guess I should not worry about memory?

? This user is from outside of this forum

Well, specific file formats typically have a header, which defines properties, such as bitrate, color depth, resolution, after which follows the raw data.

For example, if you want to join two images together, you have to read the resolution and color depth, figure out how you want to compose the two input images into the output image, do some conversion if the data is in a different format and so on.

Take a look here for example, this is a wikipedia article on BMP image format and its header:
http://en.wikipedia.org/wiki/BMP_file_format#Bitmap_file_header

tobias.hunger

Never assume that the user of your application will only ever use it for what you anticipate!

If your application can concatenate two files some user will end up trying to concatenate two blueray films with it;-)

croussou

Aha, okay I get it now thanks. What about .zip files, that's what I am mostly interested about...

Can I zip a file through my application? For example, there is a button for file creation, then another one checking if the file really exists and then a button called add to archive, where I put the file in question, in a .7z, .rar archive.

croussou

[quote author="Tobias Hunger" date="1329983973"]Never assume that the user of your application will only ever use it for what you anticipate!

If your application can concatenate two files some user will end up trying to concatenate two blueray films with it;-)[/quote]

Hehe, nice one indeed! The thing is that the user will not be able to select the files for concatenation. It would be predetermined in the application code, so that is not a big issue.

? This user is from outside of this forum

Well, it is not like something REALLY bad will happen, worst case scenario the procedure will fail in numerous possible ways. Luckily no one's foot will be literally shot off :)