New SimpleCrypt page

rich

If you do, I'd be tempted to use something like RC4 which while not perfect, is very simple to implement.

zester

Andre I think you did a great job, at documenting not only usage but also the algorithm. I wish all of Qt's examples were so well thought out ;)

katropine

Great job, easy to use. One question, I tested my app on Debian and Mint and no problem, but on Fedora 17 and Arch
I get "Invalid version or not a cyphertext."

@ QByteArray ba = cypher;

char version = ba.at(0);
if (version !=3) {  //we only work with version 3
    m_lastError = ErrorUnknownVersion;
    qWarning() << "Invalid version or not a cyphertext.";
    return QByteArray();
}@

andre

Sorry, no idea. I did not test on these sytems, but I have no clue why it would go wrong on a different linux system. That seems unlikely somehow. Perhaps the data you feed into SimpleCrypt is corrupted somehow?

katropine

Yes, sorry something else went wrong on those systems and indeed corrupted the settings string.
My Bad.

SimpleCrypt works perfectly.

amanjit

Hi,

[quote author="Andre" date="1300457411"]I have just added a "page":http://developer.qt.nokia.com/wiki/Simple_encryption in the Snippets category [/quote]

Thanks for this class. I am invoking it's constructor with my predefined key (my secret) and I am wondering why qsrand() is initialized with currentTimeMillis or similar (in the constructor code)? I don't get the same encryption results on multiple invocations so I used my quint64 key to initialize qsrand (in the constructor), then it works..

@
SimpleCrypt c1(Q_UINT64_C(0x0c2ad4a4acb9f023)); //some random number
SimpleCrypt c2(Q_UINT64_C(0x0c2ad4a4acb9f023)); //some random number

qDebug() << "Crypt1 " << c1.encryptToString(QString("justatest"));
qDebug() << "Crypt2 " << c2.encryptToString(QString("justatest"));
@

Output
@
Crypt1 "AwLLXV+ZSO+x3Ise1Aw="
Crypt2 "AwIUgoBGlzBuA1TBC9M="
@

Just wondering :)

andre

Why would you want to have the same cypher text when using the same clear text and key? As long as the decrypted plain text from these cypher texts is the same, what is the problem with having different cypher texts? The algorithm uses a randomization of the string on purpose. It makes it much harder to leak part of the key because analysis is much harder this way.

An explanation is in the "details page":/wiki/SimpleCrypt_algorithm_details#2d478ba9ee3cf03e338b506b1a0292dc that has more on the idea of using a random number as a leading byte.

You replacing that they way you did partly negates this, and thus makes the cypher weaker by a couple of bits. Note that even with your change, encrypting the same plain text using the same SimpleCrypt instance twice will result in different cypher texts.

amanjit

Hi Andre,

Thanks for answering; I wasn't looking for reasonably strong encryption - I just wanted to always get the same encrypted string for the same input (private key+string_to_be_encrypted); its just for private use anyway, and non-critical.

I am using QCryptographicHash for that now, it solves my problem

andre

Eh, no, that class does not solve your problem, if you are indeed looking for encryption rather than hashing. There is a big difference between the two...

amanjit

[quote author="Andre" date="1356878054"]Eh, no, that class does not solve your problem, if you are indeed looking for encryption rather than hashing. There is a big difference between the two... [/quote]

That's a chicken and egg problem: I don't want to elaborate on "my problem" and hence prove that I am fine with hashing because of concerns of privacy. Please understand that and thank you for your help.

topocc

worked in QT 5?

topocc

good thing I changed was this:

@//QString cypherString = QString::fromAscii(cypher.toBase64());
QString cypherString = QString::fromUtf8(cypher.toBase64());

//QString cypherString = QString::fromAscii(cypher.toBase64());
QString cypherString = QString::fromUtf8(cypher.toBase64());

//QByteArray cyphertextArray = QByteArray::fromBase64(cyphertext.toAscii());
QByteArray cyphertextArray = QByteArray::fromBase64(cyphertext.toUtf8());

//QByteArray cyphertextArray = QByteArray::fromBase64(cyphertext.toAscii());
QByteArray cyphertextArray = QByteArray::fromBase64(cyphertext.toUtf8());@

there will be well done this.

Ian Monroe

I was getting SIGABRT's when attempting to decrypt an empty string with a Qt with debugging enabled. So I've added a little check. Doesn't seem possible to link to wiki history diffs, but you can see it there.

andre

Thanks, good catch.

I assume you're talking about this snippet, right?
@
if( cypher.count() < 3 )
return QByteArray();
@

A small problem is, that no error code is set. I think that needs to be added.

topocc

good, and in QT5 probe, and all good the only thing that was included # include <QDataStream>, and change QString :: fromutf8 () and QString :: toutf8 ().

Clearly only tried with 30 words, and it has worked well.

njeisecke

Hi Andre,

thanks for sharing this very useful code. Works perfectly, did save me quite some time. May I buy you a beer on next DevDays?

Nils

andre

[quote author="njeisecke" date="1362060748"]Hi Andre,

thanks for sharing this very useful code. Works perfectly, did save me quite some time. May I buy you a beer on next DevDays?

Nils[/quote]
Good to hear that. If I'm able to go, you most certainly are welcome to buy me one :-)

pasnox

Hi,

I'm having some troubles using your code.
For the same binary the encryption/decryption of the string using a key works fine.
But if i change the source code and add something like: qWarning() << "what you want";
Then rebuild the app, the password is badly decrypted.

Is this a normal behavior ??

Thanks for your help.

andre

Well, no, of course not. However, your description is so vague that I have no idea what could be wrong.

pasnox

Hi,

Thanks for your answer i found the problem.
I was using a stupid generated test key like: quint64 key( qHash( "the_test_key" ) );
When the binary change, the hash returned by this call was not identical as previously, resulting to badly decrypted content.
Using QString version fixed the problem: quint64 key( qHash( QString( "the_test_key" ) ) );

thanks you!