QtCreator plugin for cppcheck, krazy and other tools

j1elo

Not a very good method for tool version check:
you are getting the numeric part and blindly converting to double. Well, it's a bit optimistic assumption that a version number will be a valid numeric value!

In fact, now that cppcheck went up to version 1.60.1, QPT happily states that "Tool cppcheck-gui requires a minimal version 1.55".

cmazieri

It is a bug and will be fixed soon.

As a work around try to edit the configuration file, qpt prints the path of the configuration file when it starts.
It is usually located at $HOME/.config/QtProjectTool/qpt.ini

try to clear the minimal version line, change:

Mininal_version_USE_only_digist_and_dot_it_will_be_converted_to_float=1.58

to

Mininal_version_USE_only_digist_and_dot_it_will_be_converted_to_float=

That should work.

j1elo

I did it the other way :)
Created a QByteArray w2 where to copy all the numbers without any punctuation sign. So 1.60.1 ends up being 1601 which is greater than 1.55
Maybe it's a good idea for version checking (I didn't stop to think about implications of doing this... it was just a workaround)

cmazieri

Hello,

Version 0.8 has been released with some improvements, see "RELEASE NOTES":http://sourceforge.net/projects/qtprojecttool/files/RELEASE_NOTES.txt/download

cmazieri

Version 0.8 has been released with some improvements, the main work was done to have a better Windows version.

See "RELEASE NOTES":http://sourceforge.net/projects/qtprojecttool/files/RELEASE_NOTES.txt/download

last5bits

Thank you for your tool! But I get question marks in the file paths with non-latin letters (e.g. cyrillic letters)
@$qpt -A CET.pro

/home/alex/Projects/??????/src/main.cpp
/home/alex/Projects/??????/src/mainwindow.cpp
/home/alex/Projects/??????/src/mainwindow.h@

cmazieri

Hi,

Are you using version 0.8 ?

send me your project file and the right path it should bring,

I will take a look on that.

Thanks, Carlos

last5bits

Yes, the version is 0.8. I sent you a tarball, thanks for your fast respond

cmazieri

Hi, it has been fixed (not published yet)

bq. ./qpt -A /home/carlos/tmp/projects/qpt_tests/Проекты/КириллическоеИмяПроекта/hello.pro
/home/carlos/tmp/projects/qpt_tests/Проекты/КириллическоеИмяПроекта/hello.cpp

But, I am afraid cppcheck does not handle unicode paths:

/usr/bin/cppcheck --platform=unix32 -I . -f -q --template '{file}:{line}:{id}:{message}' --inline-suppr --enable=style --enable=unusedFunction --suppress=missingInclude:* --inconclusive --file-list=/tmp/qt_temp.Lh2660

cppcheck: error: could not find or open any of the paths given.

I use full pathname for files, I will try using relative pathnames.

last5bits

[quote author="cmazieri" date="1377213999"]
But, I am afraid cppcheck does not handle unicode paths:

/usr/bin/cppcheck --platform=unix32 -I . -f -q --template '{file}:{line}:{id}:{message}' --inline-suppr --enable=style --enable=unusedFunction --suppress=missingInclude:* --inconclusive --file-list=/tmp/qt_temp.Lh2660

cppcheck: error: could not find or open any of the paths given.

I use full pathname for files, I will try using relative pathnames.
[/quote]

No, cppcheck is all right. This is what I get with cppcheck 1.60.1

@$ cat list
/home/alex/Проекты/КириллическоеИмяПроекта/hello.cpp

$ /usr/bin/cppcheck --platform=unix32 -I . -f -q --template ‘{file}:{line}:{id}:{message}’ --inline-suppr --enable=style --enable=unusedFunction --suppress=missingInclude:* --inconclusive /home/alex/Проекты/КириллическоеИмяПроекта/hello.cpp --file-list=list
‘/home/alex/Проекты/КириллическоеИмяПроекта/hello.cpp:9:unreadVariable:Variable 'a' is assigned a value that is never used.’
‘/home/alex/Проекты/КириллическоеИмяПроекта/hello.cpp:9:arrayIndexOutOfBounds:Array 'a[5]' accessed at index 5, which is out of bounds.’@

cmazieri

Hi,

Many Thanks,

I had no Unicode handling in qpt, it has been included.

Please get version "0.9":http://sourceforge.net/projects/qtprojecttool/files/0.9/qpt-source-0.9.tgz/download and let me know if you have any problem.

Regards,

bq.
[qpt running]: /usr/bin/cppcheck --platform=unix32 -I . -f -q --template '{file}:{line}:{message}' --inline-suppr --enable=style --enable=unusedFunction --inconclusive /home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/hello.cpp /home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/mz.cpp /home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/ры.cpp'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/hello.cpp:5:Variable 'x' is not assigned a value.'
'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/mz.cpp:3:Unused variable: ret'
'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/mz.cpp:4:Variable 'x' is not assigned a value.'
'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/ры.cpp:3:Unused variable: ret'
'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/ры.cpp:4:Variable 'x' is not assigned a value.'
'/home/carlos/tmp/projects/tests/test/Проекты/КириллическоеИмяПроекта/mz.cpp:1:The function 'x' is never used.'

Atlantis70

Hi,

this is a great tool. However, my top-level project file is of type "subdirs" and thus no sources are listed. Nevertheless it would be great to have this tool parsing recursively the .pro-file(s) below.

Can this be done?

Regards,

Thorsten

cmazieri

No,
qpt uses qmake to expose SOURCES and HEADERS.
A subdir project does not have it, at least I do not know.

What I do is: create a dummy project file that includes all other projects, like this:

my_cppcheck_code.pro
@
BASE = snapshot_8_22_2013

include ($$BASE/Ldap/test/regression_ldap.pro)
include ($$BASE/ProcessWindow/test/regression_jobwindow.pro)
include ($$BASE/commonLib/cmntrace/test/cmntrace.pro)
include ($$BASE/commonLib/cmncli/test/cmncli.pro)
include ($$BASE/ComboSearch/ComboSearch.def)
include ($$BASE/customHeader/test/customtable.pro)
include ($$BASE/DictPointer/DictPointer.def)
include ($$BASE/diskspace/test/diskspace.pro)
include ($$BASE/FileUtil/FileUtil.def)
include ($$BASE/Ldap/Ldap.def)
include ($$BASE/Preferences/test/regression_PreferencesEditor.pro)
include ($$BASE/Tickets/Tickets.def)
include ($$BASE/UiUtils/UiUtils.def)
include ($$BASE/tests/regression_pipa.pri)
@

Then use that dummy project my_cppcheck_code.pro to run qpt/cppcheck. You can have all those projects opened in QtCreator, so set the dummy as default to run qpt, then set the original project back as default to compile.

By the way, I am having problems to make this change work on Windows, the path comes undefined from command qpt command line.

Regards,
Carlos

last5bits

Thanks a lot, cyrillic names work like a charm!

Is it possible to get support of subdirs projects? I've tried the method you suggested but with no result. I sent you a tarball with project I used, if you have time to take a look

cmazieri

You have to include $$PWD in SOURCES and HEADERS in your .pro files, like this:
@
SOURCES += $$PWD/main.cpp
$$PWD/mainwindow.cpp

HEADERS += $$PWD/mainwindow.h

FORMS += $$PWD/mainwindow.ui
@

I used your subdirs-project-cppcheck.pro and I put an issue in main.cpp to test that:
@Starting external tool 'C:/Users/b35201/Downloads/build-qprojtool-Qt_4_85_static-Release/release/qpt.exe' -t cppcheck -q C:/Users/b35201/Downloads/subdirs-project/subdirs-project-cppcheck.pro
qpt.exe using: C:/Users/b35201/AppData/Roaming/QtProjectTool/qpt.exe.ini

[qpt.exe running]: "C:/Program Files/Cppcheck/cppcheck.exe" --platform=win32W -I . -DUNICODE -DWIN32 -f -q --template '{file}:{line}:{message}' --inline-suppr --enable=all --inconclusive --file-list=C:/Users/b35201/AppData/Local/Temp/qt_temp.Uh7436

'C:\Users\b35201\Downloads\subdirs-project\tests\test1\main.cpp:5:Variable 'x' is not assigned a value.'
'::Cppcheck cannot find all the include files (use --check-config for details)'

[qpt.exe INFO]: "C:/Program Files/Cppcheck/cppcheck.exe" finished with return code 0

[qpt.exe running]: C:/Qt/Qt5.0.2/Tools/QtCreator/bin/qtcreator.exe -client C:/Users/b35201/AppData/Local/Temp/qpt.exe0737323847436.tasks

[qpt.exe INFO]: finished with return code 0

'C:/Users/b35201/Downloads/build-qprojtool-Qt_4_85_static-Release/release/qpt.exe' finished@

I will add this procedure in the qpt manual.

Thanks,
Carlos

last5bits

Thanks, I got you

I have several issues/suggestions:

The most odd thing: launching cppcheck from external tools in QtCreator gives me one new instance of QtCreator (in addition to one I already have) Oo

Your way with additional .pro-file works, but I have no output in "Issues" tab of QtCreator

I believe, that it would be a better design to make qpt parsing subdirs-projects correctly, it is just recursive walking through the project tree, isn't it?

cmazieri

Will check that, in my test on Windows it works:
(messages pane) https://www.dropbox.com/s/aez4b2325ov0903/general_messages.png
(issues pane) https://www.dropbox.com/s/9kvd13exo16blcl/issues.png
check it there were issues, in the test you sent me I had change one file in order to have an issue.
Next release perhaps.

last5bits

"This":http://i41.tinypic.com/25i1wr5.png is what I get

cmazieri

OK, I see.

I have just posted a new version "0.9":http://sourceforge.net/projects/qtprojecttool/files/0.9/qpt-source-0.9.tgz/download over the previous version.
I have tested this version against several qtcreator versions I have, Qt4 and Qt5, the only difference that can make explain somethingis that which has QTimer::singleShot(3800, ..).

If it still does not work, try to increase that value and see if it works.

@diff -w 09/src/backendtool.cpp 09-ok/src/backendtool.cpp
204c204,206
<

#if DEBUG
qDebug() << Q_FUNC_INFO << "cmd" << cmd;
#endif
273a276,281
if (m_taskFile)
{
QTimer::singleShot(3800, this, SLOT(finishQtcPluginInvoke()));
}
else
{
275a284
}
356,357d364
< if (QFile(fields[0]).exists())
< {
361a369,370
if (fields.count() > 1 && QFile(fields[0]).exists())
{
398c407
< qDebug() << Q_FUNC_INFO << taskFile() << "ret" << ret;

qDebug() << Q_FUNC_INFO << taskFile&#40;&#41; << "ret" << ret << "size" << m_taskFile->size();

419d427
<
445,446c453,454
< qDebug() << "plugin" << qtcreator;
< #endif

m_taskFile->copy("taskfile_deb.task");
#endif //DEBUG
451a460,463
else
{
Util::info(qtcreator, QLatin1String("running"));
}
@

Please let me know if it solves the problem or not.

Regards,
Carlos

b4silio

Hey there! First of all thanks for making this tool, very much appreciated!

It works flawlessly on OSX, but I notice that there is an issue with qmake projects using the SUBDIRS template. Indeed there are no .cpp files on the main project file itself, so one has to individually select each subfolder and run the code on there. (otherwise the list of files created and passed to cppcheck/razy is empty)

To have it running on qt creator I just changed %{CurrentProject:FilePath} into %{CurrentDocument:FilePath} and launch the tool from within each .pro file in the subfolders.