QLabel::setPixmap() doesn't show image!

David406

Hi, I'm using setPixmap() method to draw images on a label, but met a problem. Originally, the label has its background set with a pixmap, let call it pixmap1, with setPixmap(pixmap1). Then I copy this pixmap and use it as the paint device to draw images on it. After painting is done, I then reset this label's pixmap with this modified copy, let's call it pixmap2, using its set method setPixmap(pixmap2). However, the pixmap on the label wouldn't change in any way. What's strange is that when I save this label's modified pixmap into a png file, everything is all right, and the saved pixmap is correctly modified as I paint images on it.

I really have no idea what's going wrong here. Could anyone give some suggestions?

In case you need it, here's the code snippet:

    else if (status == ScreenShot::IsToDrawLine && me->buttons() == Qt::LeftButton)
    {
        drawLine(pixmapForDrawing, me->pos());
        selectedImageLabel->setPixmap(pixmapForDrawing);
        QString filename = "D:\\test.png";
        (selectedImageLabel->pixmap())->save(filename);
    }

VRonin

continuation from https://forum.qt.io/topic/77745/setpixmap-doesn-t-show-image

This is not the final solution, by any means but could you add QApplication::ProcessEvents(QEventLoop::ExcludeUserInputEvents); after selectedImageLabel->setPixmap(pixmapForDrawing);? and see if the image changes?

Where are you calling this snippet from?

David406

@VRonin
Thank you!

This snippet is in the overloaded mouseMoveEvent(QMouseEvent *me) function.

In my last post several days ago, according to your suggestion, I correctly set the pixmap of a label by avoiding subclassing QLabel. But here, I met similar problem again! I couldn't reset QLabel's pixmap. Anyways, I will try your suggestion and let's see the result!

David406

@VRonin said in QLabel::setPixmap() doesn't show image!:

QApplication::ProcessEvents(QEventLoop::ExcludeUserInputEvents);

Hi, I added this to the code, but still didn't work.

J.Hilk

@David406
hi,
maybe you haven't released your pixmap correctly when you're finished with the drawing?

You could also try to convert you QPixmap to a QImage, as a step in between

QImage = pixmapForDrawing.toImage();
selectedImageLabel->setPixmap( QPixmap::fromImage(pixmapForDrawing));

to see, if that changes anything.

David406

@J.Hilk
Thanks.
Did you mean:

        drawLine(pixmapForDrawing, me->pos());
        QImage imageForDrawing = pixmapForDrawing.toImage();
        selectedImageLabel->setPixmap(QPixmap::fromImage(imageForDrawing));
        QString filename = "D:\\test.png";
        (selectedImageLabel->pixmap())->save(filename);

This didn't work. The saved png file is right, but not showing on the label.

Oh, this is my drawLine method, although I don't think it's relevent:

void ScreenShot::drawLine(QPixmap &pixmap, const QPoint &endPoint)
{
    QPainter painter(&pixmap);
    painter.setPen(QPen(myPenColor, myPenWidth, Qt::SolidLine, Qt::RoundCap,
                        Qt::RoundJoin));
    painter.drawLine(selectedImageLabel->mapFromGlobal(lastPenPoint),
                     selectedImageLabel->mapFromGlobal(endPoint));
    //painter.drawLine(QPoint(0, 0), QPoint(1000, 1000));
    lastPenPoint = endPoint;
}

VRonin

@David406 said in QLabel::setPixmap() doesn't show image!:

avoiding subclassing QLabel. But here, I met similar problem again!

Are you subclassing QLabel? could you show us the code of that subclass?

David406

@VRonin
No, the selectedImageLabel is just an instance of QLabel, not a subclass instance. It's created as a member in the ScreenShot class:

QLabel *selectedImageLabel;

J.Hilk

@David406
ok to make sure, it works at all. Would this show the correct Image?

drawLine(pixmapForDrawing, me->pos());
QLabel *lbl = new QLabel();
lbl->setPixmap(pixmapForDrawing);
lbl->show();

David406

@J.Hilk
This works correctly: A series of windows pops up with lines painted on the original pixmap.

J.Hilk

@David406
Alright, we narrowed the problem down. It's with selectedImageLabel. My guess, if its a standard QLabel, the pixmap is somewhere else overwriten.

David406

@J.Hilk
Thanks.
Yes, it's the problem somewhere with selectedImageLabel. But I don't quite understand what you mean by saying overwritten. The saved pixmap of selectedImageLabel is all right. It just doesn't update and show up on the label.

J.Hilk

@David406
Out of the top of my head, I can only think of 3 reasons, why a QLabel wouldn't show a pixmap.

It gets a new Pixmap(overwritten) before the paintevent could draw the old one
The Lable is actually not visible. Other widget on top or hidden
A stylesheet forces a different image to be drawn.

David406

@J.Hilk
Thanks.
The functionality of my code is:

Select an area of the screen with mouse and set the selected image to label, move and show the label on the selected area dynamicly.
After selection is done, images can be drawn on the label.

And now, the first part of my code works correctly, here is how it actually works:

alt text

In the above picture, the highlighted area is actually a label with selected image as its pixmap. So you can see the label is shown correctly.

However, the second part of my code doesn't work. Namely, pixmap on the label can't be updated (or reset) with its original pixmap modified.

David406

Thank you all, finally I found that the problem is in the implementation of paintEvent().