Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. General and Desktop
  4. Why some examples don't delete the pointer member newed in the destructor?

Why some examples don't delete the pointer member newed in the destructor?

Scheduled Pinned Locked Moved Solved General and Desktop
3 Posts 2 Posters 797 Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • D Offline
    D Offline
    doodle
    wrote on last edited by
    #1

    E.g in "audio" example :
    widget.h:

    class Widget : public QWidget
    {
        Q_OBJECT
    
    public:
        Widget(QWidget *parent = 0);
        ~Widget();
    
    private:
        XYSeriesIODevice *m_device;
        QChart *m_chart;
        QLineSeries *m_series;
        QAudioInput *m_audioInput;
    };
    

    widget.cpp:

    Widget::Widget(QWidget *parent)
        : QWidget(parent),
          m_device(0),
          m_chart(0),
          m_series(0),
          m_audioInput(0)
    {
        m_chart = new QChart;
        QChartView *chartView = new QChartView(m_chart);
        chartView->setMinimumSize(800, 600);
        m_series = new QLineSeries;
        m_chart->addSeries(m_series);
        QValueAxis *axisX = new QValueAxis;
        axisX->setRange(0, 2000);
        axisX->setLabelFormat("%g");
        axisX->setTitleText("Samples");
        QValueAxis *axisY = new QValueAxis;
        axisY->setRange(-1, 1);
        axisY->setTitleText("Audio level");
        m_chart->setAxisX(axisX, m_series);
        m_chart->setAxisY(axisY, m_series);
        m_chart->legend()->hide();
        m_chart->setTitle("Data from the microphone");
    
        QVBoxLayout *mainLayout = new QVBoxLayout;
        mainLayout->addWidget(chartView);
        setLayout(mainLayout);
    
        QAudioFormat formatAudio;
        formatAudio.setSampleRate(8000);
        formatAudio.setChannelCount(1);
        formatAudio.setSampleSize(8);
        formatAudio.setCodec("audio/pcm");
        formatAudio.setByteOrder(QAudioFormat::LittleEndian);
        formatAudio.setSampleType(QAudioFormat::UnSignedInt);
    
        QAudioDeviceInfo inputDevices = QAudioDeviceInfo::defaultInputDevice();
        m_audioInput = new QAudioInput(inputDevices,formatAudio, this);
    
        m_device = new XYSeriesIODevice(m_series, this);
        m_device->open(QIODevice::WriteOnly);
    
        m_audioInput->start(m_device);
    }
    
    Widget::~Widget()
    {
        m_audioInput->stop();
        m_device->close();
    }
    
    XYSeriesIODevice *m_device;
    QChart *m_chart;
    QLineSeries *m_series;
    QAudioInput *m_audioInput;
    

    All of them don't have parent to be deleted, but the destructor has not deleted them.

    raven-worxR 1 Reply Last reply
    0
    • D doodle

      E.g in "audio" example :
      widget.h:

      class Widget : public QWidget
      {
          Q_OBJECT
      
      public:
          Widget(QWidget *parent = 0);
          ~Widget();
      
      private:
          XYSeriesIODevice *m_device;
          QChart *m_chart;
          QLineSeries *m_series;
          QAudioInput *m_audioInput;
      };
      

      widget.cpp:

      Widget::Widget(QWidget *parent)
          : QWidget(parent),
            m_device(0),
            m_chart(0),
            m_series(0),
            m_audioInput(0)
      {
          m_chart = new QChart;
          QChartView *chartView = new QChartView(m_chart);
          chartView->setMinimumSize(800, 600);
          m_series = new QLineSeries;
          m_chart->addSeries(m_series);
          QValueAxis *axisX = new QValueAxis;
          axisX->setRange(0, 2000);
          axisX->setLabelFormat("%g");
          axisX->setTitleText("Samples");
          QValueAxis *axisY = new QValueAxis;
          axisY->setRange(-1, 1);
          axisY->setTitleText("Audio level");
          m_chart->setAxisX(axisX, m_series);
          m_chart->setAxisY(axisY, m_series);
          m_chart->legend()->hide();
          m_chart->setTitle("Data from the microphone");
      
          QVBoxLayout *mainLayout = new QVBoxLayout;
          mainLayout->addWidget(chartView);
          setLayout(mainLayout);
      
          QAudioFormat formatAudio;
          formatAudio.setSampleRate(8000);
          formatAudio.setChannelCount(1);
          formatAudio.setSampleSize(8);
          formatAudio.setCodec("audio/pcm");
          formatAudio.setByteOrder(QAudioFormat::LittleEndian);
          formatAudio.setSampleType(QAudioFormat::UnSignedInt);
      
          QAudioDeviceInfo inputDevices = QAudioDeviceInfo::defaultInputDevice();
          m_audioInput = new QAudioInput(inputDevices,formatAudio, this);
      
          m_device = new XYSeriesIODevice(m_series, this);
          m_device->open(QIODevice::WriteOnly);
      
          m_audioInput->start(m_device);
      }
      
      Widget::~Widget()
      {
          m_audioInput->stop();
          m_device->close();
      }
      
      XYSeriesIODevice *m_device;
      QChart *m_chart;
      QLineSeries *m_series;
      QAudioInput *m_audioInput;
      

      All of them don't have parent to be deleted, but the destructor has not deleted them.

      raven-worxR Offline
      raven-worxR Offline
      raven-worx
      Moderators
      wrote on last edited by
      #2

      @doodle
      because a widget gets the parent set as soon as it is added to a layout, or to be more specific when the layout then gets installed on a widget.
      Some other objects take owndership of the objects when they are passed as parameter.
      Like m_chart to chartView widget, which then gets added to a layout.

      So they are all deleted implicitly when the container widget gets deleted.

      --- SUPPORT REQUESTS VIA CHAT WILL BE IGNORED ---
      If you have a question please use the forum so others can benefit from the solution in the future

      1 Reply Last reply
      2
      • D Offline
        D Offline
        doodle
        wrote on last edited by
        #3

        Got it! :)

        1 Reply Last reply
        0

        • Login

        • Login or register to search.
        • First post
          Last post
        0
        • Categories
        • Recent
        • Tags
        • Popular
        • Users
        • Groups
        • Search
        • Get Qt Extensions
        • Unsolved