ASSERT failure in QList<T>::at: "index out of range"

Qjay

Hey all i am getting this error

ASSERT failure in QList<T>::at: "index out of range", file ../../Qt5.7.0/5.7/gcc_64/include/QtCore/qlist.h, line 537

So i am trying to download images from a List of links ( StringList )

Screenshot of what is happening

https://s31.postimg.org/8l3unwe1n/assert.gif

below is my code snippet ( i have not pasted whole code it's too big )

Code snippet :

 dbmanager *d = new dbmanager(0) ;
    d->doDownload(down_links);

    dbmanager *p = new dbmanager(0) ;
    p->png_download(png_down_links, png_hash);

    return true ;

}


//start downloading images




void dbmanager::doDownload(const QVariant& v)
{
    if (v.type() == QVariant::StringList) {


        QNetworkAccessManager *manager= new QNetworkAccessManager(this);

        QUrl url = v.toStringList().at(current);
        qDebug() << "why break" << url;

        filename = url.toString().remove("http://restbase.wikitolearn.org/en.wikitolearn.org/v1/media/math/render/svg/");
        qDebug() << filename;
        m_network_reply = manager->get(QNetworkRequest(QUrl(url)));

        connect(m_network_reply, SIGNAL(downloadProgress (qint64, qint64)),this, SLOT(updateDownloadProgress(qint64, qint64)));
        connect(m_network_reply,SIGNAL(finished()),this,SLOT(downloadFinished()));


    }
}



void dbmanager::downloadFinished(){
    qDebug()<<filename;
    if(m_network_reply->error() == QNetworkReply::NoError){


        m_file =  new QFile(imgpath+"/"+filename+".svg");
        qDebug()<<imgpath+"/"+filename;
        if(!m_file->open(QIODevice::ReadWrite | QIODevice::Truncate)){
            qDebug() << m_file->errorString();
        }
        m_file->write(m_network_reply->readAll());

        QByteArray bytes = m_network_reply->readAll();
        QString str = QString::fromUtf8(bytes.data(), bytes.size());
        int statusCode = m_network_reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
        qDebug() << QVariant(statusCode).toString();
    }
    m_file->flush();
    m_file->close();
    int total = down_links.count();
    if(current<total-1){
        current++;
        qDebug()<<"current = "<<current<<"total = "<<total;
        doDownload(down_links);}
    else if(current==total-1)
    {
        qDebug()<<"download complete";
    }

    bool success = false ;
    QString fname = filename;
    success = add_depend(fname,revision_number);
    if(success == true)
    {
        qDebug() <<"added in dependency table";
    }
    else
    {
        qDebug() << " error in adding to dependency table";
    }


}


void dbmanager::updateDownloadProgress(qint64 bytesRead, qint64 totalBytes)
{
    //    ui->progressBar->setMaximum(totalBytes);
    //    ui->progressBar->setValue(bytesRead);
    qDebug()<<bytesRead<<totalBytes;
}

Explanation :

down_links : contains list of download links . These contatin links i am sure , i used qDebug() << down_links to check them

the problem that i was able to identify till now is this :

 QUrl url = v.toStringList().at(current);
        qDebug() << "why break" << url;

in above code url should contatin download link but it does not , it is empty .

SGaist

Hi,

Did you check that you call doDownload with an non-empty QStringList ?

Also, why use QVariant if you will only handle string list in that method ?

On a side note, you have a memory leak, each time that function is called you create a new QNetworkAccessManager but never delete it. All instances will get destroyed when their parent also is but in between they will slowly fill your memory.

Qjay

Yes i did checked that the doen_links (string list) is not empty.

I did qDebug() << down_links.size();

To check the size of the list.

For instance in the givrn screenshot the page that i tried to download had 33 links

SGaist

Did you also check the value of current ?

Paul Colby

Hi @Qjay

Where do you initialise dbmanager::current? And, are you re-using the dbmanager instance?

eg:

d->doDownload(one_set_of_down_links);
// later
d->doDownload(another_set_of_down_links);

In which case you might need to be explicitly resetting dbmanager::current to 0? (and if the second list was smaller than the first, you will get the exception you've shown)

Cheers.

Qjay

hi @Paul like in my case

 dbmanager *d = new dbmanager(0) ;
    d->doDownload(down_links);

    dbmanager *p = new dbmanager(0) ;
    p->png_download(png_down_links, png_hash);

i use
int current= 0 // for doDownload(down_links)
png_curr = 0; // for png_download

here is the whole code of the .cpp file

https://ghostbin.com/paste/rdfnb

Qjay

@SGaist

Yes i check the value of current .

it is in global scope and i have initialized it to 0

int current = 0 ;

i have attached the full source code too

https://ghostbin.com/paste/rdfnb

and this is how i am calling the add function which calls save image and save file function

   Item{
                visible: false
                Text{
                    visible: false
                    id: responsetext
                    text:""
                }
            }

            Button{
                width: drawer.width
                height: 40

                text:"save offline"
                onClicked: {
                    responsetext.text = dbman.add(current_title);
                    drawer.close();

                }
            }

SGaist

Why a global variable ?

If you have an out of range error this means that current goes higher than the size of the list your are accessing.

You are likely never reinitializing current. So it will work the first time however the second time, and unless your array gets bigger than current, it will fail.

Paul Colby

@Qjay, how sure are you that the exception happens at this line?

QUrl url = v.toStringList().at(current);

Did the debugger break at this line?

The reasons I ask are,

the output in your animated gif suggests (its not definitive) to me that the crash happens just after that point;
its looks very likely to me, that the exception would be on this line:

png_filename = n.toStringList().at(png_curr);

Because the code in dbmanager::png_download is assuming that n (aka png_hash) always has the same number (or rather, at least as many) items as v (aka png_down_links). But, while I see code that streams entries into png_down_links (in save_images), I see no code anywhere that adds anything to png_hash.

I highly recommend you try out the debugger (if you haven't already), and also add some range-checking / debug logging in the dbmanager::png_download function.

Cheers.

Qjay

@Paul i think you are right . I think my code is messed up ( this code is an older version ) . Yeah i just saw png_hash has nothing to do in whole code !!

I have updated the code

https://ghostbin.com/paste/j4meh

Qjay

@Paul @SGaist , i don't know why but i am never able to initialize QUrl url :( ;

AND I BELIEVE THAT"S WHAT CAUSING THE PROBLEM

i have tried different approaches too . Like in my code i was using QStringList i even tried Qvector<QString> down_links and end result was same

NOT ABLE TO set QUrl

in console screen
QUrl("")
""

What shoudl i do ?

jsulm

@Qjay Can you show the code where you initialize QUrl? From your description we can only guess what could be the problem. Are you sure you don't pass an empty string to QUrl?

Qjay

@jsulm , i have given the whole code

https://ghostbin.com/paste/v4t47

by the way this is where i set QUrl

line no 371

 QUrl url = v.toStringList().at(current);
        qDebug() << "why break" << url;

SGaist

Again, did you check that the value of current is lower than the size of the string list ?

Qjay

I have initialized current =0; in global scope .

jsulm

@Qjay But is it changed somewhere?
Why not just check like this?

qDebug() << v.toStringList().size() << current;
qDebug() << v.toStringList().at(current);
QUrl url = v.toStringList().at(current);

In such a situation this is actually the first thing to do...

Qjay

hey @jsulm

i tried what you suggested

qDebug() << v.toStringList().size() << current;
qDebug() << v.toStringList().at(current);
QUrl url = v.toStringList().at(current);

i did this

qDebug() << "stringlist size and current" << v.toStringList().size() << current;
        qDebug() << "current url in stringlist" << v.toStringList().at(current);
        QUrl url = v.toStringList().at(current);
        qDebug() << "why break" << url;

output

stringlist size and current 33 0
current url in stringlist   "(http://restbase.wikitolearn.org/en.wikitolearn.org/v1/media/math/render/svg/3cd95482da53d42c5f7f249454f7ee1e85cacc0c)"
why break QUrl("")
""

and then error

ASSERT failure in QList<T>::at: "index out of range", file ../../Qt5.7.0/5.7/gcc_64/include/QtCore/qlist.h, line 537
The program has unexpectedly finished.

jsulm

@Qjay Why is the URL in parentheses?

(http://restbase.wikitolearn.org/en.wikitolearn.org/v1/media/math/render/svg/3cd95482da53d42c5f7f249454f7ee1e85cacc0c)

SGaist

Looks like you are doing a lot of parsing, replacement etc.

The first thing I'd do, is to just ensure that you really have URLs in your list. And get rid of that QVariant parameter. It really doesn't make any sense in your use case.

Qjay

Hello , thanks for the suggetions .

yes there were useless ( ) in url . i have removed them . Now i am able to assign url to Qurl :D great!!
i removed the Qvariant thing too

now the code is

.cpp : https://ghostbin.com/paste/vv2w7

header file : https://ghostbin.com/paste/8z4y3

but the assert error still exist :/

SGaist

Still at the same place ?

Qjay

Hey @SGaist , @jsulm , thank you it's solved now

To be honest i don't know why it worked :/

but below is the code

https://ghostbin.com/paste/528m6

SGaist

From the looks of it, you're currently lucky.

I'd recommend considering refactoring and cleaning up this code. Maybe a full rewrite would even be better.

Qjay

I too was also thinking of full rewrite but i don't have much time for that right now :/ .