QtSerialPort contribution
-
I've just added support of IBM OS/2 (Serenity eComStation) to QtSerialPort library. I commited the changes are in "OS2" branch.
May I merge "OS2" branch with "5.3" (or other official) branch? -
Hi and welcome to devnet,
In order to get your code included in Qt you have to go through gerrit first and get the devs to review it. "here":http://qt-project.org/wiki/Setting-up-Gerrit and "here":http://qt-project.org/wiki/Gerrit-Introduction for more informations
-
Just read the article and pushed it to 5.3 branch.
I succeed, but received automatically generated reviews from Qt Sanity Bot. There are some issues in them.
Do I have to correct them and try to push again, or I just may wait response from devs? -
There are already available responses, please read them. :)
-
[quote author="kuzulis" date="1421696732"]There are already available responses, please read them. :)[/quote]
Ok, thanx!