Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. Game Development
  4. QtSerialPort contribution

QtSerialPort contribution

Scheduled Pinned Locked Moved Game Development
5 Posts 3 Posters 1.7k Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • Y Offline
    Y Offline
    Yagiza
    wrote on last edited by
    #1

    I've just added support of IBM OS/2 (Serenity eComStation) to QtSerialPort library. I commited the changes are in "OS2" branch.
    May I merge "OS2" branch with "5.3" (or other official) branch?

    1 Reply Last reply
    0
    • SGaistS Offline
      SGaistS Offline
      SGaist
      Lifetime Qt Champion
      wrote on last edited by
      #2

      Hi and welcome to devnet,

      In order to get your code included in Qt you have to go through gerrit first and get the devs to review it. "here":http://qt-project.org/wiki/Setting-up-Gerrit and "here":http://qt-project.org/wiki/Gerrit-Introduction for more informations

      Interested in AI ? www.idiap.ch
      Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

      1 Reply Last reply
      0
      • Y Offline
        Y Offline
        Yagiza
        wrote on last edited by
        #3

        Just read the article and pushed it to 5.3 branch.
        I succeed, but received automatically generated reviews from Qt Sanity Bot. There are some issues in them.
        Do I have to correct them and try to push again, or I just may wait response from devs?

        1 Reply Last reply
        0
        • K Offline
          K Offline
          kuzulis
          Qt Champions 2020
          wrote on last edited by
          #4

          There are already available responses, please read them. :)

          1 Reply Last reply
          0
          • Y Offline
            Y Offline
            Yagiza
            wrote on last edited by
            #5

            [quote author="kuzulis" date="1421696732"]There are already available responses, please read them. :)[/quote]
            Ok, thanx!

            1 Reply Last reply
            0

            • Login

            • Login or register to search.
            • First post
              Last post
            0
            • Categories
            • Recent
            • Tags
            • Popular
            • Users
            • Groups
            • Search
            • Get Qt Extensions
            • Unsolved