Adding QByteArray

? Offline

I have two binary files, of which I have no clue about their data organization. I have them as QByteArray stream and overlap them meaning a[i]=b[i]+c[i].

I made an attempt with

@
QByteArray x,y,z
for(k=0;k<x.size();k++){
for(l=0;l<y.size();l++){
if(k=l){
z[k]=x[k]+y[l];
z.append(z[k]);
}
}
}
@

I know that it was a naive attempt but couldn't do more as I have no clue about the internal data organization, all I know is they are binary. Any suggestions or help please !!

[EDIT: code formatting; please use @-tags and proper indentation, Volker]

lycis

First: Please use code tags (@) to wrap your code. This will make it much easier to read.

What do you want to achieve?

And what's a QByteStream? I never heard of that type of stream - but that may be my limited knowledge...

I can't find anything wrong in your code - but since I don't know what you're expecting to be the result I don't feel like I could give you any hint.

? Offline

I am sorry . . It should be QByteArray. I want add the content of two binary files which are generated from a file. The overlap makes the output better outcome apropos the original.

dbzhang800

I could not understand the code too. Perhaps QByteStream is Is a spelling error, which is QByteArray?

Seems they are equal to following code:
@
for(k=0;k<qMin(x.size(), y.size());k++){
z[k]=x[k]+y[k];
z.append(z[k]);
}
@

which is very strange.

dbzhang800

[quote author="christopher09" date="1335892180"]I am sorry . . It should be QByteArray. I want add the content of two binary files which are generated from a file. The overlap makes the output better outcome apropos the original.[/quote]

So, you mean?

@
QByteArray z;
for(int k=0;k<qMin(x.size(), y.size());k++){
z.append(x[k]+y[k]);
}
@

? Offline

Yes, but its not working.
[quote author="1+1=2" date="1335892778"][quote author="christopher09" date="1335892180"]I am sorry . . It should be QByteArray. I want add the content of two binary files which are generated from a file. The overlap makes the output better outcome apropos the original.[/quote]

So, you mean?

@
QByteArray z;
for(int k=0;k<qMin(x.size(), y.size());k++){
z.append(x[k]+y[k]);
}
@[/quote]

dbzhang800

[quote author="christopher09" date="1335905550"]Yes, but its not working.
[/quote]
So, how do you come to this conclusion?

? Offline

Unhandled exception at 0x75eb9673 in app.exe= Microsoft C++ exception: std::bad_alloc at memory location 0x001dc99c..
[quote author="1+1=2" date="1335906112"]
[quote author="christopher09" date="1335905550"]Yes, but its not working.
[/quote]
So, how do you come to this conclusion?[/quote]

dbzhang800

[quote author="christopher09" date="1335912902"]Unhandled exception at 0x75eb9673 in app.exe= Microsoft C++ exception: std::bad_alloc at memory location 0x001dc99c..
[/quote]

I don't think above code will cause such an exception. what you need is: debug your application.

In additon, you can play with examples like this:
@
#include <QtCore>

int main()
{
QByteArray x("\x01\x02\x03\x04"), y("\x05\x06\x07");

QByteArray z;
for(int k=0;k<qMin(x.size(), y.size());k++){
     z.append(x[k]+y[k]);
}

qDebug()<<z.toHex();
return 0;

}
@

? Offline

On compiling, Unhandled exception at 0x00c90364 in app.exe: 0xC0000005: Access violation reading location 0x00141934.
[quote author="1+1=2" date="1335913456"]
[quote author="christopher09" date="1335912902"]Unhandled exception at 0x75eb9673 in app.exe= Microsoft C++ exception: std::bad_alloc at memory location 0x001dc99c..
[/quote]

I don't think above code will cause such an exception. what you need is: debug your application.

In additon, you can play with examples like this:
@
#include <QtCore>

int main()
{
QByteArray x("\x01\x02\x03\x04"), y("\x05\x06\x07");

QByteArray z;
for(int k=0;k<qMin(x.size(), y.size());k++){
     z.append(x[k]+y[k]);
}

qDebug()<<z.toHex();
return 0;

}
@[/quote]

dbzhang800

Obviously, what you given is a runtime error instead of compile errors.

If you are sure that above example will cause this exception under your environment, please debug it first and tell us which line trigger the exception.

? Offline

I am writing the binary files using following method.

@
//....
typedef std::basic_ofstream<unsigned char, std::char_traits<unsigned char> > uofstream;
uofstream op(filename, ios::out | ios::binary);
op.write(size, 5);
op.write(RGrBl, widthheight3);
op.write(a,widthheightdifference);/difference is int size[4]
op.close();
@

I want to add the values at each BYTE in the files created by above function. I am unable to write it because of exception at run time saying bad memory allocation, and referring to mlock.c

I just want to add the hex values at all the bytes but I am getting exceptions at time saying bad memory allocation and referring to mlock.c. I am using

@
//x and y are read from files created using the above
QByteArray alpha; for(int k=0;k<qMin(x.size(), y.size());k++){ alpha.append(x[k]-y[k]); } qDebug()<<z.toHex();
QByteArray beta; for(int j=0;j<qMin(x.size(),alpha.size());++j) { alpha.append(x[j]+z[j]); } qDebug()<<beta.toHex();
@

What could be wrong in this ?
Thanks

[EDIT: code formatting, Volker]

? Offline

Please use @-tags for your code snippets or click on the code icon (the rightmost icon) in the editor. This way your code is formatted nicely and your chances that anyone takes care of what your write are much higher.

I've added them for you a last time.

Thanks.

http://www.catb.org/~esr/faqs/smart-questions.html

andre

I have to wonder: what do you hope to achieve by adding together values from two binary files who's formats you don't know? Who or what is supposed to use and make sense of the resulting file afterwards? And are you sure you want to just add two chars? How do you deal with overflows?

It just looks generally weird to me.

? Offline

I am basically extracting the difference between a original image and the the image I could save to the disk. So, the difference when added to the original should give the file without any difference.
[quote author="Andre" date="1336045803"]I have to wonder: what do you hope to achieve by adding together values from two binary files who's formats you don't know? Who or what is supposed to use and make sense of the resulting file afterwards? And are you sure you want to just add two chars? How do you deal with overflows?

It just looks generally weird to me. [/quote]

andre

So... you're trying to create some kind of patch file for a binary file?

? Offline

Yes in a way. A patch with difference is created and added to the original to remove the disparity in output image.
[quote author="Andre" date="1336048685"]So... you're trying to create some kind of patch file for a binary file?[/quote]

andre

What's the use of doing that? Note that your way of patching will only work if both files have the same size, and will produce files that have the same size as the original. I really fail to see the point of this excersise.

? Offline

They'll be all the time.To keep it simple, it may be said that an encryption is patched to make it lossless.
[quote author="Andre" date="1336050201"]What's the use of doing that? Note that your way of patching will only work if both files have the same size, and will produce files that have the same size as the original. I really fail to see the point of this excersise.[/quote]

andre

You really lost me. If you want file encryption, I think there are better ways. Good luck with your project though!