Waiting for QNetworkManager in a test

[Uncle_Masta]

I have some old code that wraps QNetworkAccessManager that I'm cleaning up and adding tests. I've been reviewing how threads and the event loop works.

So, really basic: Sending a request with QNetworkAccessManager.get() will, as I understand it, do the work in a separate thread. But, our slots that we connect to the finished signals are going to be executed in the thread that the test slots tests are in. Am I right so far?

So, we don't want to exit the test until our slots connected to receiving results signals are called. How do we do that without blocking the event loop?

Or, am I "doing it wrong"?

[Christian Ehrlicher]

As for all other async stuff to test use QTest::qWait().

[ChrisW67]

The QNetworkAccessManager and request processing is happening in another thread. You have to enter a main test thread event loop to kick this off and then you do block until finished() is emitted (or timeout reached as in the qWait case).

Something like this also flies:

#include <QtTest>

// add necessary includes here
#include <QNetworkAccessManager>

class ExampleQNAMTest : public QObject
{
    Q_OBJECT

public:
    ExampleQNAMTest();
    ~ExampleQNAMTest();

private slots:
    void test_case1();
};

ExampleQNAMTest::ExampleQNAMTest() {}

ExampleQNAMTest::~ExampleQNAMTest() {}

void ExampleQNAMTest::test_case1() {
    QNetworkAccessManager mgr;
    QSignalSpy spy(&mgr, &QNetworkAccessManager::encrypted);
    QEventLoop loop;
    connect(&mgr, &QNetworkAccessManager::finished, &loop, &QEventLoop::quit);

    QNetworkRequest req(QUrl("https://www.google.com"));
    QNetworkReply *reply = mgr.get(req);
    QVERIFY(reply);  
    loop.exec();

    QCOMPARE(spy.count(), 1);     // did it get encrypted
}

QTEST_MAIN(ExampleQNAMTest)

#include "tst_exampleqnamtest.moc"

[Uncle_Masta]

@ChrisW67 said in Waiting for QNetworkManager in a test:

QSignalSpy

QSignalSpy?! Cool!

[Uncle_Masta]

@Christian-Ehrlicher Ah! That's what I needed. Thanks!!