Important: Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

same signal-slot connection in two windows



  • @russjohn834 I wonder if you need a different approach here.
    Are those QMainWindows at the same level? I mean, are they created in some "higher level" container object?
    If so, maybe you need to move the handling of the battery event and LED on/off task there. I'm thinking what will happen if you need to add 2 more windows, are you going to connect the api and LED handling in those new windows as well? and then you're asked to add 2 more windows... it seems not good for app maintenance...



  • @mrjj @Pablo-J-Rogina Thanks.

    just a quick question, how can I switch following into the new Signal-slot syntax?

      connect(&api, SIGNAL(tetraGripEvent(STIM_GUI_TOPIC_T, uint8_t, uint32_t )), this, SLOT(eventHandler(STIM_GUI_TOPIC_T , uint8_t , uint32_t )));
    
    

    here api is global variable



  • @russjohn834

    Hello!

    The new Signal-slot syntax will be like this:

    connect(this, &Test::tetraGripEvent, this, &Test::eventHandler);
    

    Note: this is just a test example. Where the Test is your current class and it emitting a signal and receiving it. Also, you can do it using lambda.

    connect(this, &Test::tetraGripEvent, [this](STIM_GUI_TOPIC_T a, uint8_t b, uint32_t c) {
        eventHandler(a, b, c);
    });
    

    You need to provide more info about the api global variable, where and how you have initialized it?



  • @Cobra91151 Thank you.

    I define the instance of my API class in the main as follows:

    tetra_grip_api api; ------------>class instance
    
    int main(int argc, char *argv[])
    {
        QApplication a(argc, argv);
    
        api.openSerialPort();
        QObject::connect(api.serial, SIGNAL(readyRead()), &api, SLOT(readData()));
    
        Settings w(nullptr);
        w.show();
        return a.exec();
    }
    
    

    In this case, how do I switch the following expression into the new signal-slot syntax?

    connect(&api, SIGNAL(tetraGripEvent(STIM_GUI_TOPIC_T, uint8_t, uint32_t )), this, SLOT(eventHandlerTwo(STIM_GUI_TOPIC_T , uint8_t , uint32_t )));
    


  • If this is of your class Settings the following should work.

    connect(&api, &tetra_grip_api::tetraGripEvent, this, &Settings::eventHandlerTwo);
    

    Otherwise replace the second class by the correct one.



  • @jazzco2 Thanks a lot.

    The new connect syntax seems ok. It did not complain about anything. But I'm not getting the expected output. Just to summarize.

    I'm calling QMainWindow Patients from Settings. In the Patients constructor, I did connect as follows:

    connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo);
    

    When I put a breakpoint in the connect statement, it did not went into the eventHandlerTwo slot. which means something wrong in the way I did the connection.

    where api is global variable.

    eventHandlerTwo is a public slot:

    void Patients::eventHandlerTwo( STIM_GUI_TOPIC_T topic, uint8_t reg, uint32_t value)
    {
        if (topic==TOPIC_STIMULATOR)
        {
            switch(reg)
            {
            case STIM_REG_BATTERY_CAPACITY_REMAINING:
    
                if(value<86)
                    ui->qLed_p2->setOnColor(QLed::Red);
                else
                    ui->qLed_p2->setOnColor(QLed::Green);
                    ui->qLed_p2->setValue(true);
                break;
            }
        }
        ui->label_batteryVal->setText(QString::number(value));
     }
    
    

    Patients being called from Settings as follows:

    void Settings::on_pushButton_patients_clicked()
    {
    
        hide();
        stagetwo = new Patients(this);
        stagetwo -> show();
    }
    

    Any thoughts?


  • Lifetime Qt Champion

    So where do you call your connect() statement?



  • @russjohn834 said in same signal-slot connection in two windows:

    connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo);

    When I put a breakpoint in the connect statement, it did not went into the eventHandlerTwo slot. which means something wrong in the way I did connection.

    What do you mean? When the connect statement is executed it will not cause any entry into Patients::eventHandlerTwo, that only comes when the signal is later emitted.



  • @Christian-Ehrlicher

    Connect is called as in the following:

    
    Patients::Patients(QWidget *parent) :
        QMainWindow(parent),
        ui(new Ui::Patients)
    {
        ui->setupUi(this);
    
    
        this->setStyleSheet("background-color: white;");
        this->setFixedSize(this->width(),this->height());
    
    
    
        connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo); //--->connect is called here
        
    // Setup table
        ui->tableWidget->setColumnCount(5);
        ui->tableWidget->setHorizontalHeaderLabels(QStringList{"Patient ID","Name", "Surname", "LastSession", "Note"});
        ui->tableWidget->horizontalHeader()->setSectionResizeMode(QHeaderView::Stretch);
        ui->tableWidget->setSelectionBehavior(QAbstractItemView::SelectRows);
    
    
    
         QString path = QCoreApplication::applicationDirPath()+"/data/";
    
    
    
        QStringList qdiFilter("*.xml");
    
    
        QDirIterator qdi( path, qdiFilter, QDir::Files);
        while (qdi.hasNext())
        {
            parseDataEntry(qdi.next());
        }
    
    }
    


  • @JonB

    I'm connecting with the same signal in the previous window , so do I need to disconnect that and connection to use the same signal in with a new slot?

    Basically in Settings window this works:

     connect(&api, &tetra_grip_api::tetraGripEvent,this, &Settings::eventHandler); //--> slot is eventHandler
    

    But in Patients this is not working:

       connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo);//--->Slot is eventHandlerTwo
    


  • @russjohn834
    So I now take it you mean you find the slot does not get entered, not the the connect fails?

    No, you do not have to disconnect, a signal may have any number of slots attached. Though if a previously-attached slot does not return, or misbehaves like if the slot instance is no longer around, it is possible the second slot might not get called.

    So if debugging what is going you might be advised to temporarily not connect the Settings slot, just the Patients slot and concentrate on sorting that out. It is not possible to say from what you have posted why one slot works and the other does not.



  • @JonB Thank you. I tried to connect only the Patients slot but cant see where I'm wrong..

    Patients window is opened from Settings as given below:

    void Settings::on_pushButton_patients_clicked()
    {
    
        hide();
        stagetwo = new Patients(this);
        stagetwo -> show();
    }
    

    Where stagetwo is public

    public:
         Settings(QString,QWidget *parent = nullptr);
        ~Settings();
         Patients *stagetwo;
    

    Anything wrong I'm doing here!?



  • Hi all,

    I just noticed this thing if I call both my Settings and Patients from my main the connection is successful (see below)

    #include <QApplication>
    
    tetra_grip_api api;
    
    int main(int argc, char *argv[])
    {
        QApplication a(argc, argv);
    
        api.openSerialPort();
    
        QObject::connect(api.serial, SIGNAL(readyRead()), &api, SLOT(readData()));
        QObject::connect(api.serial, SIGNAL(error(QSerialPort::SerialPortError)),&api, SLOT(ErrorHandler(QSerialPort::SerialPortError))); // error handling
    
        Settings w(nullptr);
        w.show();
    
        Patients v(nullptr); //---------> this makes connection successfull
        v.show();
    
        return a.exec();
    }
    

    but instead, if I call Patients from Settings even though the connection is successful im not getting the expected output.

    My signal source api is a global variable which is initialized in the main as shown above.
    So constructing both classes in the main makes connection ok and I'm gettting expected output. But if I call one window from other makes connection true but my slot is not being called at all.

    What is the reason for this?



  • @russjohn834
    If you're asking me to guess, show how you gain access to tetra_grip_api api; from Settings/Patients? In these cases where do you do the connect()s from? And, how do you know your connect()s are successful?


  • Lifetime Qt Champion

    Hi,

    @russjohn834 said in same signal-slot connection in two windows:

    QObject::connect(api.serial, SIGNAL(readyRead()), &api, SLOT(readData()));
    QObject::connect(api.serial, SIGNAL(error(QSerialPort::SerialPortError)),&api, SLOT(ErrorHandler(QSerialPort::SerialPortError))); // error handling

    Since serial is internal to api why don't you connect it in the constructor of your tetra_grip_api class ?



  • @JonB

    This is how I make the connection in Settings.

    Settings::Settings(QString patientLabel, QWidget *parent) : QMainWindow(parent)
        , ui(new Ui::Settings)
    {
        ui->setupUi(this);
       
        connect(&api, &tetra_grip_api::tetraGripEvent,this, &Settings::eventHandler);
    }
    

    Connection is successfull (qDebug()<<connect(....) gives TRUE) also the a QLabel and an LED in the eventHandler slot works perfectly.

    In the same way I try to connect in the Patients:

    Patients::Patients(QWidget *parent) : QMainWindow(parent)
        , ui(new Ui::Patients)
    {
        ui->setupUi(this);
       
        connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo);
    }
    

    here connection is successfull (qDebug()<<connect(....) gives TRUE) but the a QLabel and an LED in the eventHandlerTwo are not working.



  • @russjohn834
    How do I know &api refers to the same, global, initialized api instance in both cases?
    And I see nothing in code about any QLabel in either case, not mentioned by you before...
    You have to supply the necessary/relevant code if you want people to help.
    Use a debugger to make sure whether slots are being hit.



  • @JonB

    I thought api should be known and accessible to all classes if intialized as global in the main.cpp

    #include <QApplication>
    
    tetra_grip_api api; //-------------> api instance
    
    int main(int argc, char *argv[])
    {
        QApplication a(argc, argv);
    
        api.openSerialPort();
        QObject::connect(api.serial, SIGNAL(readyRead()), &api, SLOT(readData()));
        QObject::connect(api.serial, SIGNAL(error(QSerialPort::SerialPortError)),&api, SLOT(ErrorHandler(QSerialPort::SerialPortError))); // error handling
    
    
        Settings w(nullptr);
        w.show();
    
        return a.exec();
    }
    

    Correct me if I'm wrong.



  • @russjohn834
    Your Settings & Patients classes are defined in a different source module from main.cpp, right? So how do they gain access to reference the api symbol in order to compile?

     connect(&api, &tetra_grip_api::tetraGripEvent,this, &Patients::eventHandlerTwo);
    

    I am having to tease out each bit of relevant information, one at a time....



  • @JonB
    Correct. I actually did not do anything other that making apiinstance as global in main.cpp. That might be the issue. But dont know how to proceed. How do I make Patients classes know about global api instance?


  • Lifetime Qt Champion

    @russjohn834 You should avoid global variables as much as possible.
    Just pass the pointer to api to Settings & Patients constructors...



  • Did you ensure that the connection in Patients is done before the signal tetra_grip_api::tetraGripEvent is emitted? Some qDebugs around connection, in the very first line of Patients::eventHandlerTwo and in the deconstructor of Patients should help to prove that.



  • @russjohn834 said in same signal-slot connection in two windows:

    @JonB
    Correct. I actually did not do anything other that making apiinstance as global in main.cpp. That might be the issue. But dont know how to proceed. How do I make Patients classes know about global api instance?

    I truly, truly do not understand. You said your program runs but does/does not behave properly in the cases you mentioned. I asked how you can even compile your Settings/Patients modules/.cpp source files which contain the line connect(&api, ..., when api is defined in main.cpp? From what you have said/shown they should error at compile-time with a "No such variable: api" message. So I will leave others to help, who obviously understand your source code better than I.



  • @JonB Yes, that's interesting. You can't include main.cpp in Settings or in Patients. So main.cpps line

    tetra_grip_api api; //-------------> api instance
    

    isn't visible anywhere!



  • @russjohn834 If you are using QtCreator: When you go on the &api in your connect statements in both Settings and Patients and press F2 - where does it lead you to?



  • @jazzco2

    From both Settings and Patients , &api leads me here:

    #ifndef TETRA_GRIP_API_H
    #define TETRA_GRIP_API_H
    
    #include <QObject>
    #include <stdio.h>
    #include <stdlib.h>
    #include <iostream>
    #include <QLabel>
    #include <QMessageBox>
    #include <QTimer>
    
    #define _CRT_SECURE_NO_DEPRECATE
    
    class tetra_grip_api : public QObject
    {
        Q_OBJECT
    
    public:
        explicit tetra_grip_api(QObject *parent = nullptr);
    
        #define MAX_CONFIG_FILE_LENGTH (10000)
    
         void static send_config_file(QByteArray config, bool nonvolatile);
         void static send_long_register(uint8_t, uint32_t, uint8_t *);
         void static stimulation_set_current(unsigned int, unsigned int);
    
         QSerialPort *serial = nullptr;
    
         QTimer autoConnectionTimer;
         bool tryToAutoconnect;
    
    signals:
    
         void tetraGripEvent(STIM_GUI_TOPIC_T topic, uint8_t reg, uint32_t value);
    
    
    
    public slots:
    
         void openSerialPort();
         void closeSerialPort();
         void readData();
    
    
    private slots:
    
         void ErrorHandler(QSerialPort::SerialPortError error);
    
    private:
    
            QString comPortName;
    
    };
    
    extern tetra_grip_api api;  //----------> it leads me here
    
    #endif // TETRA_GRIP_API_H
    

  • Lifetime Qt Champion

    @russjohn834 said in same signal-slot connection in two windows:

    extern tetra_grip_api api;

    You really should not do it like this. Pass pointer to the constructors of the classes which need it.



  • @jazzco2 said in same signal-slot connection in two windows:

    @JonB Yes, that's interesting. You can't include main.cpp in Settings or in Patients.

    No, but you might be including main.h, and maybe you have extern tetra_grip_api api; there, that's the sort of thing I was trying to understand. Which finally you have shown is actually in tetra_grip_api.h, which I guess you are including into each of them?

    For the line there

    extern tetra_grip_api api;
    

    does the docs for tetra_grip_api say you are responsible for defining tetra_grip_api api; yourself like you have done in main.cpp, or does it say they (the library) are defining that global instance and you are supposed to use their instance?



  • @russjohn834 Yes, pass the pointer - and then your api can be a local variable in main. No need to define it outside as main lives as long as the application is running.



  • @jazzco2

    Could you give me an example to show how do I pass a pointer to the constructor of the classes? for ex. if I need to use it in in Settings and Patients classes ?


  • Lifetime Qt Champion

    @russjohn834 said in same signal-slot connection in two windows:

    Could you give me an example to show how do I pass a pointer to the constructor of the classes?

    Well

    tetra_grip_api api;
    Settings settings(&api);
    

    Of cource you have to change the constructor, but this is C++ basic stuff.



  • @JonB

    it did not mention anything like that. My primary requirement is to use tetra_grip_api(which is a class containing all serial communication objects) instance in every form class. That's why I made it global, but now I realize it's not a good way of programming!



  • @russjohn834 said in same signal-slot connection in two windows:
    Yes and no, it gets complicated. You may not need to pass it around that way.

    It looks like the tetra_grip_api is something in-house to you, it does not exist on the web. You have shown that tetra_grip_api.h file contains the line:

    extern tetra_grip_api api;  //----------> it leads me here
    

    You should ask the author of that file whether he intends:

    1. It is up to you to go tetra_grip_api api once in one of your own files, in order to define it, as you have done in your main.cpp; OR

    2. The tetra_grip_api library already contains this definition for you, and you are supposed to use that one.

    For now, humour me:

    Go into your main.cpp. Locate the line which reads:

    tetra_grip_api api; //-------------> api instance
    

    Now comment out that line.

    Try to rebuild & relink. What happens? Do you end up, after the linking, with an error message like: "Unresolved symbol: ''tetra_grip_api", or not?

    • If there is no error, see whether your program behaves correctly now.

    • If there is an error, unfortunately it's time we saw all your relevant code which should work but does not, because there is way too much incomplete information in what you have posted. I hesitate to say this, because I have a bad feeling that's going to be (at least) 3 .cpp files & 3 .h. files. Which is an awful lot for to paste and for us to look through :( If you could cut it down to a relevant, minimal subset which reproduces the bad behaviour you say you see, that would be really good....



  • @JonB Thanks a lot for your feedback.

    Commenting out of tetra_grip_api api in the main.cpp did end up in multiple errors with "Unresolved external symbol class tetra_grip_api api".

    From the suggestions from you guys, I feel like there is something wrong in making use of global variables. I should try also the other way of passing pointer to the class.

    But I was trying to understand a reason program behaves this way.

    As I mentioned earlier , If I call Patients behaves badly if I call it from Settings. But instead If I call both Patieints and Settings in the main (as shown below), both behave as expected. Do you immedatly think of any reason for this!?

    #include <QApplication>
    
    tetra_grip_api api;
    
    int main(int argc, char *argv[])
    {
        QApplication a(argc, argv);
    
        api.openSerialPort();
        QObject::connect(api.serial, SIGNAL(readyRead()), &api, SLOT(readData()));
        QObject::connect(api.serial, SIGNAL(error(QSerialPort::SerialPortError)),&api, SLOT(ErrorHandler(QSerialPort::SerialPortError))); // error handling
    
    
        Settings  w(nullptr); //---->this behaves right
        Patients  v(nullptr); //---- >this behaves right
        v.show();
        w.show();
    
        return a.exec();
    }
    


  • @russjohn834
    No, because you show the case which works OK. We need to see exactly how Settings calls Patients, plus the signal connections, with whatever is relevant to that case, to judge where the problem is.



  • @JonB

    This is how I call Patients from Settings

    void Settings::on_pushButton_patients_clicked()
    {
        this->close();
        stagetwo = new Patients(this);
        stagetwo -> show();
    }
    

    where stagetwo is public

    public:
         Settings(QString,QWidget *parent = nullptr);
        ~Settings();
         Patients *stagetwo;
    

    In the Patients signal connection is as below:

    Patients::Patients( QWidget *parent) :
        QMainWindow(parent),
        ui(new Ui::Patients)
    {
        ui->setupUi(this);
    
    connect(&api, &tetra_grip_api::tetraGripEvent,this, &StageTwoPatients::eventHandlerTwo);
    
    }
    


  • @russjohn834 said in same signal-slot connection in two windows:

    void Settings::on_pushButton_patients_clicked()
    {
    this->close();
    stagetwo = new Patients(this);
    stagetwo -> show();
    }

    Just to humour me, replace by

    void Settings::on_pushButton_patients_clicked()
    {
        // this->close();
        // stagetwo = new Patients(this);
        stagetwo = new Patients(nullptr);
        stagetwo -> show();
    }
    

    Any better behaviour?



  • @JonB

    Can't see any change.



  • @russjohn834
    Very last thing: how do you know slot is not being called? Please place a breakpoint on it.



  • @JonB
    I did try with a breakpoint, and convinced that the slot is not being called when the Patients window is constructed.
    So I guess that's a serious issue using global class instance. Though I was trying to understand why this is happening ..


Log in to reply