OpenRpt: 1st Report Engin ported to Qt5
-
Hi!
A Qt5 port is nice, but it should maintain Qt4 compatibility, as the companies using it have not switched to Qt5 yet. It's quite easy to be able to compile for both, as long as one avoids Qt5 - only features. A fork at this moment would be a bad idea for maintaining the code, as the bulk of the users and QA will stay on the Qt4 side of the fence for now. I can help with Qt4 compatibility and for discussing the issue with xTuple.
-
I'm wondering what's the benefit of applying Qt4 compatibility!! this is really none sense it's just like applying applying Qt3 compatibility to Qt4!!!
xTuple has to convert their project to Qt5 because Qt4 sooner or later will be from the past (at most for a year). I personally contact them about this issue and they didn't give it damn attention so the forked project has to be done by the community
By the way I started my fork but Ahmed was more prescience :)
-
[quote author="mbnoimi" date="1368310371"]I'm wondering what's the benefit of applying Qt4 compatibility!! this is really none sense[/quote]
No, it's not. Qt5 has removed and changed alot that makes things significantly worse for some developers. Just some examples from my experience: Significant changes in QPointer-vs-QWeakPointer functionality, Complete removal of PostScript support, Complete removal of OpenGL graphicssystem (QApplication::setGraphicsSystem), still a huge bug in QPainter line drawing that makes it unusable for precise graphics (Qt 4.7 was the last working version in that respect).
And the list goes on and on. That's why switching to Qt5 is not an option for most people – after all, there is no benefit either, since the added features are mostly just on the QML side. So Qt4 will absolutely be around for many, many years to come in professional applications and libraries. -
[quote author="mbnoimi" date="1368310371"]I'm wondering what's the benefit of applying Qt4 compatibility!! this is really none sense it's just like applying applying Qt3 compatibility to Qt4!!!
[/quote]Qt4+Qt5 compatibility is very different from Qt3 compatibility, it's just some conditionnal includes and .pro definitions. So, it's not a big burden, and, as said previously, quite valuable at the moment.[quote author="mbnoimi" date="1368310371"]xTuple has to convert their project to Qt5 because Qt4 sooner or later will be from the past (at most for a year). I personally contact them about this issue and they didn't give it damn attention so the forked project has to be done by the community[/quote]They are moving towards a web client, so it's possible that they'll not migrate to Qt5 at all - but they're not the only company using OpenRPT.
-
[quote author="gadlim" date="1368361916"]
Qt4+Qt5 compatibility is very different from Qt3 compatibility, it's just some conditionnal includes and .pro definitions. So, it's not a big burden, and, as said previously, quite valuable at the moment.[/quote]
It's simple... you can modify Qt5 project for making it available in Qt4. Personally I really don't interst in it and looking forward not backward :\[quote]They are moving towards a web client, so it's possible that they'll not migrate to Qt5 at all[/quote]
This is their problem, it seems that they're focusing on web interface.[quote]but they're not the only company using OpenRPT.[/quote]
Why that companies don't contribute in the code then? this is really selfish :( -
[quote author="mbnoimi" date="1368436528"]It's simple... you can modify Qt5 project for making it available in Qt4. Personally I really don't interst in it and looking forward not backward :[/quote]The Qt5 project is already out of sync with the official repository (some recent fixes), so it would be a bit more work. I'll see what i can do. If xTuple allows to commit a Qt5+Qt4 port in the repository, i'll do it there, that would be a lot more convenient for future maintenance.
[quote author="mbnoimi" date="1368436528"][quote]but they're not the only company using OpenRPT.[/quote]Why that companies don't contribute in the code then? this is really selfish :(
[/quote]Some did. If they're not interested in Qt5 at the moment, you can't blame them (you're doing the same for Qt4 after all, that's also selfish, isn't it ?). -
xTuple is OK for a Qt5+Qt4 version on the current trunk, i'll work on it this week.
NB i assumed that this Qt5 port was based on a recent (march ou april) version, but it's actually based on 3.31beta :-/ -
The Qt5 compatibility patch is commited in the "OpenRPT trunk":http://sourceforge.net/p/postbooks/code/HEAD/tree/openrpt/trunk/. I'd advise starting from this instead of the gitorious project.
-
[quote author="gadlim" date="1368718824"]The Qt5 compatibility patch is commited in the "OpenRPT trunk":http://sourceforge.net/p/postbooks/code/HEAD/tree/openrpt/trunk/. I'd advise starting from this instead of the gitorious project.[/quote]
You mean this trunk doesn't support Qt5 yet?!
-
Yes it does now, didn't I say that ?
BTW the project has now moved to "gitub":https://github.com/xtuple/openrpt. -
[quote author="gadlim" date="1373372885"]Yes it does now, didn't I say that ?
BTW the project has now moved to "gitub":https://github.com/xtuple/openrpt.[/quote]I cloned recent git repository, It still need tons of modifications to be able to run over Qt5!
-
bq. I cloned recent git repository, It still need tons of modifications to be able to run over Qt5!
Oops my mistake. It only needs some renames for "TRUE" and "FALSE" then building process will run smoothly.
Thanks,
P.S. May you correct github repository?
-
The TRUE/FALSE issue should already be corrected too (see "here":https://github.com/xtuple/openrpt/commit/fad750532544cfb1ce52bd8fff01796563a780f1).
Where did you have to do the renaming ? -
I don't know how to use Git (I'm bzr fan) so I don't know how to ask for merge into Github but you can find unrenamed strings at:
- MetaSQL/metasqlhighlighter.cpp
- OpenRPT/wrtembed/documentscene.h
- OpenRPT/wrtembed/graphicsitems.h
- OpenRPT/wrtembed/graphicssection.h
-
You're right, and that's wrong. I'll send a merge request for the fix.
Thanks for the heads up. -
I've pushed the fix and it has been merged in the main repository.
I've tested that the project compiles correctly with Win/MSVC and Win/MinGW (previously it was only working on Win/MSVC), with Qt 5.1. -
New Qt report tool - LimeReport - Qt report generator with embedded / standalone designer.
www.limereport.ru
limereport.sourceforge.net